Skip to content

feat: add retry button to error toast in deposit screen - #524

Merged
overprodigy merged 2 commits into
Heliobond:mainfrom
BABAT-CODE:feat/error-toast-retry-button
Sep 2, 2026
Merged

feat: add retry button to error toast in deposit screen#524
overprodigy merged 2 commits into
Heliobond:mainfrom
BABAT-CODE:feat/error-toast-retry-button

Conversation

@BABAT-CODE

Copy link
Copy Markdown
Contributor
  • Extract deposit submission logic into handleSubmitDeposit callback
  • Show error toast with retry button instead of inline error message
  • Retry button triggers resubmission of failed transaction
  • Improved UX for failed transactions with clear recovery path

closes #427

Summary

Linked issue

Closes #

Type of change

  • Bug fix
  • Feature
  • Localization (i18n)
  • Accessibility
  • Smart contract / on-chain wiring
  • Docs / chore

Screenshots / screencast

Checklist

  • Tied to an accepted issue (Closes #…)
  • bun run build passes locally (builds + type-checks)
  • Follows the design system — token CSS vars, sentence case, mono numerals, deltas carry sign + arrow, no emoji, no hardcoded colours
  • User-facing strings added to both messages/en.json and messages/fr.json (if any copy changed)
  • Accessible — keyboard operable, visible focus, reduced-motion respected
  • No secrets committed
  • Docs updated where relevant

- Extract deposit submission logic into handleSubmitDeposit callback
- Show error toast with retry button instead of inline error message
- Retry button triggers resubmission of failed transaction
- Improved UX for failed transactions with clear recovery path

closes Heliobond#2
@BABAT-CODE
BABAT-CODE requested a review from dadadave80 as a code owner August 31, 2026 18:06
@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@BABAT-CODE Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@BABAT-CODE is attempting to deploy a commit to the David Dada's projects Team on Vercel.

A member of the Team first needs to authorize it.

@sshdopey sshdopey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! Extracting the deposit logic into a reusable callback and adding a retry button to the error toast directly addresses the issue. The UX improvement is clear and the code is well-structured. Keep up the awesome contributions! ❤️

@sshdopey

Copy link
Copy Markdown
Contributor

Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready.

@dadadave80 dadadave80 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflict

@sshdopey sshdopey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! Extracting the deposit logic into a reusable callback and adding a retry button to the error toast directly addresses the issue. The code is clean and the UX improvement is clear. I noticed the success toast lost the href link to the investment, so you might want to add that back if it was intentional. Also, the retry button styling uses inline styles, but that's fine for now. Thanks for contributing! ❤️

@sshdopey

sshdopey commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready.

@overprodigy
overprodigy merged commit a5518b8 into Heliobond:main Sep 2, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Error notifications don't include action button to retry — user must manually retry

4 participants