refactor: extract styled-components definitions to theme config - #519
refactor: extract styled-components definitions to theme config#519olutundee wants to merge 4 commits into
Conversation
|
@olutundee is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
sshdopey
left a comment
There was a problem hiding this comment.
This is a solid refactor that centralizes scattered styles into a typed theme system under src/theme/, exactly addressing issue #416. The new token files, style objects, and tests are well-organized and the screens/components are updated to use them. I see some unrelated fixes (like the Explore pagination change and translation additions) that might be from a merge, but they don't detract from the core effort. Great work on the comprehensive theme configuration and keeping everything type-safe! 💚
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
dadadave80
left a comment
There was a problem hiding this comment.
please resolve conflicts
|
@olutundee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
sshdopey
left a comment
There was a problem hiding this comment.
This is a solid refactor that centralizes scattered styles into a well-organized theme system. The new src/theme/ directory with colors, spacing, typography, and style objects is exactly what issue #416 asked for, and the updates to screens and components show real effort in replacing local definitions. The tests and type checks passing is great to see. Nice work! 💚
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
This is a solid refactor that centralizes scattered styles and tokens into a well-organized theme system. The new files are clean, typed, and tested, and the updates to screens and components look consistent. I noticed a few unrelated fixes bundled in (like typo corrections and i18n additions), which is fine for a hackathon PR. Great work on the theme extraction and keeping everything passing! Keep it up! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
sshdopey
left a comment
There was a problem hiding this comment.
This is a solid refactor that centralizes scattered styles into a typed theme system under src/theme/, exactly addressing issue #416. The new token files and style objects are well-organized, and the updates to screens and components show genuine effort to eliminate duplication. Tests and typechecks pass, which is great. I noticed a few unrelated changes mixed in (like i18n keys and a webpack config tweak), but they don't detract from the core work. Nice job! Keep up the good work! ❤️
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
Overview
Extracts scattered styled definitions, inline colors, spacing tokens, and recurring style objects into a centralized, typed theme configuration system under
src/theme/.Related Issue
Closes #416
Changes
Theme System
src/theme/colors.tssrc/theme/spacing.tssrc/theme/typography.tssrc/theme/shadows.ts&src/theme/breakpoints.tssrc/theme/styles.tsCSSProperties) for cards, headings, inputs, tables, statistics, and forms.src/theme/theme.ts&src/theme/index.tsthemeobject with full TypeScript type exports.src/theme/theme.test.tsScreens & Components
src/screens/sharedStyles.tssrc/screens/creator/CreatorApplication.tsx,CreatorDashboard.tsx,ProjectBuilder.tsxsrc/screens/admin/AdminConsole.tsx,OracleForms.tsx,RegistryTable.tsxsrc/screens/Portfolio.tsxVerification Results