fix: populate investor_projects via vault event polling - #498
Open
Netty-kun wants to merge 4 commits into
Open
Conversation
|
@Netty-kun Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the notification service being a no-op in production by adding a second event poller. When
vault_contract_idis set, the poller reads the configured vault contract, decodes Deposit and ProjectFunded events, and callsstore.recordInvestmentto populate theinvestor_projectsindex. This ensuresgetInvestorsForProjectreturns recipients andnotifyInvestorsis actually invoked on investment activity.Related Issue
Closes #
Changes
🔌 Vault Event Poller
[MODIFY]
notification-service/src/config.tsvault_contract_idis now read from the environment and exposed on the config object.[MODIFY]
notification-service/src/types.tsDepositandProjectFundeddecoded event payload types.VaultEventunion to safely handle both event kinds.[MODIFY]
notification-service/src/listener.tspollVaultEvents, mirroringpollScoreChanges, that pollsvault_contract_id, decodes matching vault events, and callsstore.recordInvestment.[MODIFY]
notification-service/src/index.tsconfig.vault_contract_idis set, start the vault poller alongside the existing score poller.[MODIFY]
notification-service/src/listener.test.tsScoreChangedevent that reaches the investor.Verification Results
Closes #337