fix(financial): support dynamic discount rates in sensitivity analysi… - #613
Open
esegbueadam-sys wants to merge 4 commits into
Open
fix(financial): support dynamic discount rates in sensitivity analysi…#613esegbueadam-sys wants to merge 4 commits into
esegbueadam-sys wants to merge 4 commits into
Conversation
|
@esegbueadam-sys Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Done |
esegbueadam-sys
force-pushed
the
fix/discount-rate-sensitivity
branch
from
September 2, 2026 15:57
19e3c3e to
3298af4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(financial): resolve hardcoded discount-rate in sensitivity analysis (#522)
Description:
Refactored sensitivity analysis in src/lib/financial.ts to support dynamic discount rates.
Updated SensitivityVariation to support additive percentage-point deltas (kind: "delta").
Updated performSensitivityAnalysis to apply deltas relative to the provided discount_rate base input rather than assuming a fixed 7%.
Added regression tests in src/tests/financial.test.ts verifying accuracy for non-default discount rates (e.g., 10%).
Type of change
Testing checklist
Closes #522