fix: add startup warning when REQUEST_SIGNING_SECRET is unset (#516) - #599
Open
Fang0067 wants to merge 7 commits into
Open
fix: add startup warning when REQUEST_SIGNING_SECRET is unset (#516)#599Fang0067 wants to merge 7 commits into
Fang0067 wants to merge 7 commits into
Conversation
|
@Fang0067 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@Heliobond Hi! This PR is open and ready for review — happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a startup warning when
REQUEST_SIGNING_SECRETis not set in the environment, alerting operators that admin request signing verification is inactive.Related Issue
Closes #516
Changes
Request Signing & Server Startup
src/index.tsREQUEST_SIGNING_SECRETanalogous to theADMIN_API_KEYcheck.src/__tests__/requestSigning.test.tsREQUEST_SIGNING_SECRETis unset.Verification Results
REQUEST_SIGNING_SECRETis unsetsrc/index.ts