Fix Stellar transaction replay with sequence number guard - #561
Open
Vivian-04 wants to merge 3 commits into
Open
Fix Stellar transaction replay with sequence number guard#561Vivian-04 wants to merge 3 commits into
Vivian-04 wants to merge 3 commits into
Conversation
|
@Vivian-04 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #540 Prevent Stellar transaction replay with sequence number guard
Description
This PR addresses issue #540 where concurrent submissions of identical transactions or slow RPC responses could cause sequence number conflicts, resulting in multiple confirmable duplicated transactions on-chain.
Changes
_attemptSubmit.localSequenceTrackerboth before and after updating it from chain.Stale sequence number detectederror instead of silently rebuilding and submitting the transaction.Acceptance Criteria Met
Closes #540