feat: add default outline to jets for better overlap visibility#819
Open
feat: add default outline to jets for better overlap visibility#819
Conversation
Signed-off-by: remo-lab <remopanda7@gmail.com>
Contributor
Author
|
@EdwardMoyse please let me know if you want to tweak opacity, segment count, or outline color if needed. |
Contributor
Author
|
@EdwardMoyse is there any update on this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes #571
Description
Adds a default outline to jet cones to make overlapping jets easier to distinguish.
Each jet now gets a wireframe outline mesh when created. The outline is generated from a low-poly cylinder geometry and rendered using
EdgesGeometry, producing a clean cage (top rim, bottom rim, and vertical edges). The outline color is the jet’s own color slightly brightened to keep it visible against the semi-transparent fill.The outline mesh is named
JetOutlineso it can be managed by the selection system. When hover or selection outlines are active,EffectsManagertemporarily hides the default outline to avoid visual conflicts and restores it when the object is no longer highlighted.Also fixes a small API rename in the share-link dialog (
getStateAsJSON→saveStateAsJSON).Test plan