chore: bump node from v20 to v24 - #3
Open
liwanma wants to merge 3 commits into
Open
Conversation
Also update release.yml to use gh cli instead of deprecated ubuntu runner.
liwanma
commented
Jul 31, 2026
Comment on lines
+89
to
+93
| const text = !(mention && Slack.isMention(mentionCondition, status)) | ||
| ? tmpText | ||
| : mention.startsWith('@') | ||
| ? `<${mention}> ${tmpText}` | ||
| : `<!${mention}> ${tmpText}`; |
Author
There was a problem hiding this comment.
format check was failing because of this
Collaborator
|
Is the GHA error expected / acceptable? @liwanma |
Author
Fixed. |
liwanma
commented
Jul 31, 2026
| number: 3 | ||
| }; | ||
| export const repoUrl = `https://github.com/${commonContext.owner}/${commonContext.repo}`; | ||
| process.env.GITHUB_REPOSITORY = `${commonContext.owner}/${commonContext.repo}`; |
Author
There was a problem hiding this comment.
Updated release.yml to use GITHUB_REPOSITORY so this resolved to HENNGE/slatify instead of the expected lazy-actions/slatify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub is deprecating node20; node24 is the new default runtime.
Also updated the release.yml file to use the gh cli since ubuntu-18.04 hasn't been available since 2023. See here.