feat(tex): add has_opaque_alpha for crunch#58
Draft
mklokocka wants to merge 4 commits into
Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 78.91% 78.97% +0.06%
==========================================
Files 41 41
Lines 1873 1888 +15
==========================================
+ Hits 1478 1491 +13
- Misses 395 397 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Owner
|
Hey @mklokocka , I hope you're good |
Guekka
force-pushed
the
main
branch
3 times, most recently
from
March 22, 2026 13:36
e920955 to
79dc734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a has_opaque_alpha method for the
CrunchTextureclass.has_alphabuilt in functions does not account for actual alpha contents, just the validness of the alpha channel.Use it in format selection.