-
Notifications
You must be signed in to change notification settings - Fork 38
Implement credential sharing interface #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Josie123-Dev
merged 5 commits into
GuardZero144:main
from
bbkenny:feat/issue-63-credential-sharing-interface
Aug 24, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
80238ff
feat(sharing): build comprehensive credential sharing interface
bbkenny 92a84e2
fix(sharing): address CodeRabbit review
bbkenny fd4589e
fix(sharing): address remaining CodeRabbit review comments
bbkenny 8487ef0
fix(sharing): schedule expiry re-render from the live clock
bbkenny 89250a0
test(sharing): use a monotonic counter for UUID fallback ids
bbkenny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { isValidStellarAddress } from '@/utils/stellar-address'; | ||
|
|
||
| describe('isValidStellarAddress', () => { | ||
| it('accepts a checksum-valid Stellar ed25519 public key', () => { | ||
| expect( | ||
| isValidStellarAddress('GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF') | ||
| ).toBe(true); | ||
| }); | ||
|
|
||
| it('rejects a correctly formatted key with a bad checksum', () => { | ||
| // Same valid key with the last few chars altered to corrupt the checksum. | ||
| expect( | ||
| isValidStellarAddress('GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA') | ||
| ).toBe(false); | ||
| }); | ||
|
|
||
| it('rejects non-Stellar strings', () => { | ||
| expect(isValidStellarAddress('not-an-address')).toBe(false); | ||
| expect(isValidStellarAddress('')).toBe(false); | ||
| }); | ||
|
|
||
| it('rejects wrong lengths', () => { | ||
| expect(isValidStellarAddress('G' + 'A'.repeat(54))).toBe(false); | ||
| expect(isValidStellarAddress('G' + 'A'.repeat(56))).toBe(false); | ||
| }); | ||
|
|
||
| it('rejects lowercase characters', () => { | ||
| expect( | ||
| isValidStellarAddress('gaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaawhf') | ||
| ).toBe(false); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.