Conversation
PR GreyDGL#493 rewrote the Makefile and removed the 'config:' target while scripts/entrypoint.sh (lines 97/110) and scripts/config.sh still instruct users to run 'make config', and config.sh still printed 'make connect' hints for a target deleted together with the old Docker workflow. Restore 'config:' as a thin wrapper over the existing interactive scripts/config.sh, and point the config.sh hints at real entry points: 'make docker-shell' for in-container claude login, and 'make run TARGET=<target>' for starting the agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #518
make configfails with "No rule to make target 'config'" because PR #493's Makefile rewrite removed theconfig:target, while the interactive setup script and the container entrypoint still instruct users to run it:scripts/entrypoint.sh:97— "Please run 'make config' and select OpenRouter option"scripts/entrypoint.sh:110— "Please run 'make config' and select Anthropic option"scripts/config.sh— generated-config comments "# Generated by make config" (4 places)The historical
config:target (commit aeb3eb6) was a thin wrapper running the interactivescripts/config.sh, which still exists and works. This change restores it.Additionally,
scripts/config.shprinted four hints pointing atmake connect, a target that was deliberately removed together with the old Docker workflow in #493 (the current flow isdocker-build/docker-login/docker-shell, and the local entry point ismake run). Those hints were verified to be broken (make connect→ "No rule to make target"). They now point at real targets.Change
Makefile: re-addconfig:target →./scripts/config.sh(also added to.PHONY).scripts/config.sh:make connectno longer exists).scripts/entrypoint.shunchanged: itsmake confighints are correct again once the target is restored.Scope note
None — the fix restores a target that existed before PR #493 and corrects stale usage hints.
make connectitself is intentionally not restored: it belonged to the deleted Docker workflow (AUTH_MODE-drivendocker attach), for which the current equivalents aremake docker-shell/make run.Type of Change
Related Issue
Testing
make -n config→ prints./scripts/config.sh.make configdriven with a menu selection exercises the full interactive flow end-to-end (menu renders, selection 2 savesPENTESTGPT_AUTH_MODE=openrouterto.env.auth, completion hints show the new commands). Artifact.env.authremoved after verification.bash -n scripts/config.sh— no syntax errors.git grep -n "make connect"across the repo (Makefile + shell scripts) — no remaining references.Checklist
git diff --check origin/main...HEADpasses