Desktop: Add commit info to binaries build with Nix #3635
Merged
+33
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timon-schelling
force-pushed
the
desktop-improve-nixpkg
branch
from
2a99fb7 to
0ca8dec
Compare
timon-schelling
force-pushed
the
desktop-improve-nixpkg
branch
from
3e7a110 to
d963a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3591
before:
after:
note that branch can't be know inside nix build sandbox
and thus staysunknownIn my opinion branch tells us nothing that is not already know by the commit and should be removed entirely or at least in cases where we can't know the branch.
also added app icons as pngs to nixpkg
and removed
(Beta)tag, we are still in alpha 4 release series.