Fix Enter fails to confirm in the New Document dialog after editing values #3615
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
!build |
Member
|
|
|
Author
|
I removed the classes from the |
Member
|
!build |
|
…w document window
Co-authored-by: Timon <[email protected]>
timon-schelling
force-pushed
the
fix-enter-new-document
branch
from
513653d to
07d6a0d
Compare
Member
|
!build |
|
timon-schelling
approved these changes
Jan 13, 2026
Member
timon-schelling
left a comment
timon-schelling
left a comment
There was a problem hiding this comment.
LGTM, I would say we should merge this, having keyboard event listeners scattered in frontend code needs to be cleaned up at some point, but this is not much of a maintenance burden on its own and a good UX improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3601
Now it behaves normally:
show_solved_issue.mp4