Fix/542 compact missing properties - #553
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 132 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Compact columns record which rows have a value; reads, searches and zone maps skip the others, and the CompactStore section (v4) stores it. v1 to v3 sections still load.
The plain-read commit test waits for its read to finish instead of 300 ms, an assert in a loop names its case, and the pip pinning note gives the exact range.
Benchmark Comparison (base vs PR)Measured on the same runner to eliminate hardware variance. Full resultsNo performance regressions above configured thresholds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
compact()stored a property that a node or edge lacked as the column's empty value ('',0,0.0,false): it read back as that value,keys()listed it,IS NULLdid not match it and filters such as= 0did. Compact columns now record which rows have a value, and reads, searches and zone maps skip the others. The CompactStore section moves to v4 to store this; v1 to v3 sections still load, with every row present as before.Fixes #542
How was it tested?
crates/grafeo-engine/tests/compact_missing_properties.rs: every column type (string, non-negative and negative integer, float, bool, vector) on nodes and edges, aftercompact(), after a secondcompact()and after a reopen.column.rsandsection.rs: masked reads and zone maps, no bitmap when every row is present, a v4 round trip, and v3 sections still loading.cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings, rustdoc with-D warnings,cargo test --all-features --workspace(13,826 passed), andcargo checkfor the edge, lpg+gql, embedded, full and gql profiles.AI assistance
AI tools used: Claude Code (implementation and tests)
Summary by cubic
Fixes
compact()so missing properties stay missing instead of being read as empty values and listed bykeys(). Missing properties now remain missing after reopen; databases compacted by 0.5.44 or earlier keep the values they stored.Written for commit 5b22203. Summary will update on new commits.