Fix/548 commit completes atomically - #550
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Benchmark Comparison (base vs PR)Measured on the same runner to eliminate hardware variance. Full resultsPerformance regressions
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 125 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #
How was it tested?
AI assistance
AI tools used:
Contributor checklist
Summary by cubic
Fixes #548: commits now complete atomically. Previously a direct write, or another transaction writing what the committing one wrote, could hide the committed value from point-in-time reads, remove it on rollback, or cause two commits to replay in the wrong order after a crash; a transaction beginning during a commit could miss it.
TransactionManager::start_commitreturns aCommitGuardthat keeps the transaction in a newCommittingstate and holds a commit lock until the commit's versions, events and WAL records are written, so no other commit, transaction start, or direct write can run in between. Adds a feature-gated commit hook and integration tests, including crash-and-replay WAL coverage.Rollout
assert!calls throughout to include failure messages.Copyfrom the PythonIsolationLevelenum and moved to the renamedtry_updateatomic method.Written for commit e307161. Summary will update on new commits.