Skip to content

fix(livestream): stop all channels before pool update to avoid FAILED_PRECONDITION #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelcaamal wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −9
Open

fix(livestream): stop all channels before pool update to avoid FAILED_PRECONDITION #4312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9831093
fix(livestream): stop all channels before pool update to avoid FAILED…
angelcaamal May 8, 2026
33d31ef
fix(livestream): scope channel cleanup to test prefix to avoid FAILED…
angelcaamal May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions media/livestream/test/livestream.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ before(async () => {
parent: livestreamServiceClient.locationPath(projectId, location),
});
for (const channel of channels) {
if (channel.createTime.seconds < DATE_NOW_SEC - THREE_HOURS_IN_SEC) {
const isTestChannel = channel.name.includes(
'nodejs-test-livestream-channel'
Copy link
Copy Markdown
Contributor

@amcolin amcolin May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why are these channels being filtered, and is this defined anywhere else?

Maybe it is worth to store it in a const or a comment to provide context 🤔

Copy link
Copy Markdown
Contributor Author

@angelcaamal angelcaamal May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amcolin Great point! The old code was fetching all channels. I added this filter to make sure we only modify the channels created by this specific test, just to be safe and avoid messing with other people's channels

);
if (isTestChannel) {
const request = {
name: channel.name,
};
Expand All @@ -68,16 +71,18 @@ before(async () => {
console.log(err);
}

const [events] = await livestreamServiceClient.listEvents({
parent: channel.name,
});

for (const event of events) {
await livestreamServiceClient.deleteEvent({
name: event.name,
if (channel.createTime.seconds < DATE_NOW_SEC - THREE_HOURS_IN_SEC) {
const [events] = await livestreamServiceClient.listEvents({
parent: channel.name,
});

for (const event of events) {
await livestreamServiceClient.deleteEvent({
name: event.name,
});
}
await livestreamServiceClient.deleteChannel(request);
}
await livestreamServiceClient.deleteChannel(request);
}
}

Expand Down
Loading