Fix early return in multi-batch metric scraping#1202
Open
courageJ wants to merge 1 commit into
Open
Conversation
e6fd30a to
2651a0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Fix early return in multi-batch metric scraping
Problem
In
kubelet-to-gcm/monitor/poll.go, theOncefunction splits metrics into multiple batches (sub-requests) to avoid exceeding API limits. However, the current error handling logic uses an earlyreturnif any batch fails to be written to Google Cloud Monitoring.This causes all remaining batches in the same scraping cycle to be skipped, even if they would have succeeded. This leads to unnecessary data loss during intermittent API failures or if a single batch contains a malformed metric.
Additionally, the code contained verbose JSON marshalling and logging of failed requests, which adds unnecessary overhead and log noise.
Solution
returnwithcontinuein the batch processing loop. This ensures that a failure in one batch does not prevent subsequent batches from being attempted.MarshalJSONandlog.Warningfof the full JSON request to improve logging hygiene and performance.Testing
go build ./...).