Enforce 5s timeout on all HTTP clients in kubelet-to-gcm#1196
Merged
courageJ merged 1 commit intoMay 20, 2026
Merged
Conversation
erain
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Enforce HTTP Client Timeouts in kubelet-to-gcm
Summary
Enforces a 5-second timeout on
http.Clientinstances inkubelet-to-gcmto ensure requests finish within a predictable window and prevent potential goroutine build-up during slow backend responses.Context
Currently, the
http.Clientdefaults to an unbounded wait. This change adds a 5-second timeout to ensure that monitoring iterations remain isolated and do not accumulate if the Kubelet or GCE Metadata server is slow to respond.Changes
Timeout: 5 * time.Secondto thehttp.Clientused for GCE metadata retrieval.Timeout: 5 * time.Secondto standard and secured Kubelet HTTP clients.timepackage import.Timeout: 5 * time.Secondto the Controller HTTP client.timepackage import.Verification
go test ./monitor/kubelet/...and confirmed that existing translation logic remains sound.