Skip to content

Work with non-English base Windows images#2418

Open
graham-m-dunn wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
graham-m-dunn:localized-windows
Open

Work with non-English base Windows images#2418
graham-m-dunn wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
graham-m-dunn:localized-windows

Conversation

@graham-m-dunn
Copy link
Copy Markdown

No description provided.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: graham-m-dunn
Once this PR has been reviewed and has the lgtm label, please assign zmarano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @graham-m-dunn. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

}
Write-Host "Microsoft Edge updater completed; version found: $((Get-Item "C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe").VersionInfo.ProductVersion)"
}
# (Don't) Check if the Edge update is finished before continuing, never seems to complete in Win2022
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the script is an absolute requirement due to 2025 and windows 11 requiring it.

Without it Edge can be out of date which some customers raised that concern which is why we added it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants