Repository navigation
Conversation
gRPC status errors embed newlines ("error details: name = DebugInfo ..."),
so the warning rendered as two physical lines; log collectors treat the
second as an orphan entry. Collapse whitespace in the error text.
Collaborator
Author
|
Folded into #1199 (combined with the final-flush fix) at the reviewers' request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed in the final fail-open verification against the real API (identity without
roles/monitoring.metricWriter): the singlewarnLogger.Printfrendered as two physical lines because the gRPC status text embeds a newline beforeerror details: name = DebugInfo …. Log collectors (Cloud Logging agent, journald) treat the second line as a separate, prefix-less entry.singleLine(err)collapses whitespace in the error text; content is unchanged.TestPermanentErrorWarningIsOneLinereproduces it with aDebugInfodetail and asserts one line.Verification run that found it: 105 dials / 0 failures / p99 11 ms / Close 1 ms, exactly one warning, one deduplicated debug line, over 3.5 min with production export timings.