chore(deps): update nvidia/cuda docker tag to v12.9.2#385
Conversation
|
/gcbrun |
There was a problem hiding this comment.
Code Review
This pull request updates the CUDA base images in the Dockerfile to version 12.9.2 for both the build and runtime stages. Feedback indicates that the specified version tag is likely invalid, which will cause build failures. Additionally, the runtime image lacks critical dependencies such as nvcc, bc, and python3 that are required by the entrypoint script, leading to potential runtime errors.
| @@ -1,5 +1,5 @@ | |||
| # --- Build stage --- | |||
| FROM nvidia/cuda:12.1.0-devel-ubuntu22.04 AS builder | |||
| FROM nvidia/cuda:12.9.2-devel-ubuntu22.04 AS builder | |||
There was a problem hiding this comment.
The CUDA version 12.9.2 does not appear to be a valid tag in the official nvidia/cuda Docker Hub repository. The latest available versions in the 12.x series are currently 12.8.0 or 12.6.3. Using a non-existent tag will cause the build to fail. Please verify the version number and update it to a valid release.
|
|
||
| # --- Runtime stage --- | ||
| FROM nvidia/cuda:12.1.0-runtime-ubuntu22.04 | ||
| FROM nvidia/cuda:12.9.2-runtime-ubuntu22.04 |
There was a problem hiding this comment.
The runtime image flavor does not include the CUDA compiler (nvcc), which is required by the entrypoint.sh script's health check on line 14 (nvcc --version). This will cause the container to exit with an error immediately upon startup. Additionally, the script depends on bc and python3 (lines 59, 96, 161), which are not included in the minimal nvidia/cuda runtime image. Consider using the devel image if nvcc is required at runtime, or ensure all necessary utilities are installed in the runtime stage of the Dockerfile.
This PR contains the following updates:
12.1.0-runtime-ubuntu22.04→12.9.2-runtime-ubuntu22.0412.1.0-devel-ubuntu22.04→12.9.2-devel-ubuntu22.04Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.