Skip to content

exclude static envs from failed deploys check #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigneshrajsb merged 1 commit into from
Oct 23, 2025
Merged

exclude static envs from failed deploys check #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions src/server/services/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,22 +333,26 @@ export default class GithubService extends Service {
if (!buildId) {
logger.error(`[BUILD ${build?.uuid}][handlePushWebhook][buidIdError] No build ID found for this build!`);
}
// Only check for failed deploys on PR environments, not static environments
let hasFailedDeploys = false;
if (!build.isStatic) {
const failedDeploys = await models.Deploy.query()
.where('buildId', buildId)
.where('active', true)
.whereIn('status', [DeployStatus.ERROR, DeployStatus.BUILD_FAILED, DeployStatus.DEPLOY_FAILED]);

hasFailedDeploys = failedDeploys.length > 0;

if (hasFailedDeploys) {
logger.info(
`[BUILD ${build?.uuid}] Detected ${failedDeploys.length} failed deploy(s). Triggering full redeploy for push on repo: ${repoName} branch: ${branchName}`
);
}
}

// Check if any deploys for this build have failed previously
const failedDeploys = await models.Deploy.query()
.where('buildId', buildId)
.where('active', true)
.whereIn('status', [DeployStatus.ERROR, DeployStatus.BUILD_FAILED, DeployStatus.DEPLOY_FAILED]);

const hasFailedDeploys = failedDeploys.length > 0;

logger.info(
`[BUILD ${build?.uuid}] ${
hasFailedDeploys
? `Detected ${failedDeploys.length} failed deploy(s). Triggering full redeploy`
: 'Deploying build'
} for push on repo: ${repoName} branch: ${branchName}`
);
if (!hasFailedDeploys) {
logger.info(`[BUILD ${build?.uuid}] Deploying build for push on repo: ${repoName} branch: ${branchName}`);
}

await this.db.services.BuildService.resolveAndDeployBuildQueue.add('resolve-deploy', {
buildId,
Expand Down