add cluster annotation for codefresh builds. deploys - #36
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds cluster annotation support to differentiate Codefresh builds and deploys across different clusters. The change introduces an eksCluster annotation that is set from the lifecycleDefaults.deployCluster configuration value.
Key changes:
- Added
deployClusterparameter to build options and passed through the deployment pipeline - Updated Helm YAML generation to include
eksClusterannotation with fallback to 'unknown' - Enhanced test fixtures to validate the new annotation behavior
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/services/deploy.ts | Added deployCluster parameter to build options from lifecycleDefaults |
| src/server/lib/helm/helm.ts | Updated Helm YAML generation to include eksCluster annotation |
| src/server/lib/codefresh/utils/generateYaml.ts | Added eksCluster annotation to Codefresh YAML generation |
| src/server/lib/codefresh/types.ts | Added deployCluster as optional property to ContainerBuildOptions |
| src/server/lib/codefresh/utils/tests/generateYaml.test.ts | Updated test to validate eksCluster annotation |
| src/server/lib/codefresh/fixtures/codefresh.ts | Added deployCluster field to test fixtures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
vmelikyan
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds additional annotation
eksClusterto differentiate if deploys are across different clustersexample: