Skip to content

feat: configurable labels - #17

Merged
vigneshrajsb merged 2 commits into
GoodRxOSS:mainfrom
vigneshrajsb:configurable-labels
Jun 30, 2025
Merged

feat: configurable labels#17
vigneshrajsb merged 2 commits into
GoodRxOSS:mainfrom
vigneshrajsb:configurable-labels

Conversation

@vigneshrajsb

@vigneshrajsb vigneshrajsb commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

What

  • removes fastly purge cache label
  • uses config to set default labels to deploy, destroy and status comment
  • config to enable status comments by default. eg orgs with no UI

Testing

auto_deploy:
- create PR, add label ✅
- close PR, remove label ✅
- default status comment = true, add status comment ✅
- default status comment = false, no status comment ✅
- default status comment = false, no status comment, add custom label to get status comment ✅
---


non auto deploy:
- create PR, add label ✅
- close PR, remove label ✅
- default status comment = true, add status comment ✅
- default status comment = false, no status comment ✅
- default status comment = false, no status comment, add custom label to get status comment ✅
---
- disabled label with deploy ✅
- disable label removing deploy ✅

missing config for labels
- create PR, add label ⏳, deploy PR ✅
- close PR, remove label ⏳ ✅

- removes fastly purge cache label
- uses config to set default labels to deploy, destroy and status
comment
- config to enable status comments by default. eg orgs with no UI
@vigneshrajsb
vigneshrajsb requested a review from a team as a code owner June 30, 2025 07:33

@vmelikyan vmelikyan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, thank you @vigneshrajsb

@vigneshrajsb
vigneshrajsb merged commit 6bffaf7 into GoodRxOSS:main Jun 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants