Repository navigation
feat(escrow-backend): format ledger columns for DB storage - #584
Merged
1 commit merged intoSep 26, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
Add DB-column precision formatting to audit_ledger_sum_checker with fixed-point rendering, precision-loss validation, and row formatting. 12 new tests.
|
@broda-spendy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
godamongstmen897
pushed a commit
that referenced
this pull request
Sep 26, 2026
#579 and #584 both appended a new section to the end of audit_ledger_sum_checker.ts (parameter warning codes vs DB-column precision formatting). Keep both; no shared identifiers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PJM5SuF3hAuKGMpPBz7Rwr
godamongstmen897
pushed a commit
that referenced
this pull request
Sep 26, 2026
Keep both sides: #584's DB-format error codes, imports and tests alongside #585's split-sum assertion code, import and tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PJM5SuF3hAuKGMpPBz7Rwr
godamongstmen897
pushed a commit
that referenced
this pull request
Sep 26, 2026
- audit_ledger_sum_checker: keep #580's rate-limit error codes, rate limiting and ticker fallback alongside #584/#585's additions, and keep all three test sections. - financial_report_exporter: #580 created a third module at the same path. Append it, renaming its ERROR_CODES and FinancialReportErrorCode to EXPORTER_PARAM_ERROR_CODES and FinancialReportParamErrorCode (both names were taken by #573/#582) and folding its digit-limit-validator import into the existing one. #580's tests move to financial_report_exporter_params.test.ts. - #580 makes validateLedgerAmount reject negative amounts itself, so #579's collectParameterWarnings reported them as ENTRY_INVALID / AMOUNT_NOT_INTEGER instead of AMOUNT_NEGATIVE. Detect the negative input in the failure branch and report AMOUNT_NEGATIVE again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PJM5SuF3hAuKGMpPBz7Rwr
godamongstmen897
closed this pull request by merging all changes
into
Goldii-locks:main
in
f39bed4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DB-column precision formatting to audit_ledger_sum_checker: fixed-point rendering, round-trip precision validation, and row formatting with full-precision guarantees plus 12 tests. Verified: jest 47 passed, tsc clean, eslint clean. Closes #498