Avoid use-after-free with overlay keys - #188
Merged
Merged
Conversation
The design of Godot's CharString class means that it is unsafe to store the result of the expression `.utf8().get_data()`, as the intermediate CharString is discarded and the char* is then pointing at garbage data. Using the expression fully inline is safe, as the memory survives until after we return from passing it to OpenVR.
Collaborator
Author
|
cc @dfgHiatus, you'll probably want to cherry-pick this to the Babble overlay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design of Godot's CharString class means that it is unsafe to store the result of the expression
.utf8().get_data(), as the intermediate CharString is discarded and the char* is then pointing at garbage data. Using the expression fully inline is safe, as the memory survives until after we return from passing it to OpenVR.Going to look into whether its possible to create a linter rule to prevent this in the future.