Repository navigation
Fix highlight_updated causing errors - #892
Open
mubinulhaque wants to merge 1 commit into
Open
mubinulhaque wants to merge 1 commit into
mubinulhaque wants to merge 1 commit into
Conversation
Contributor
Author
|
A quick code search shows that the first parameter |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that both
XRToolsSnapZoneandXRToolsPickablehave a signal calledhighlight_updated. I had mistakenly assumed that only the latter had the signal, which meant that the highlight classes were connecting to these signals and trying to cast the Snap Zones as Pickables, as shown below:I have now corrected the typing in the signals to instead have the pickable as
Node3D, rather thanXRToolsPickable.Testing
The
Pickablesdemo had no issues not present inmaster. Reloading the project with this scene now no longer causes errors.Disclaimer
No generative AI was used to enhance or create the code given here.