Repository navigation
Use GridContainers for User Settings UI instead of HBoxContainers - #881
Merged
BastiaanOlij merged 1 commit intoOct 8, 2026
Merged
Conversation
mubinulhaque
force-pushed
the
user_settings_ui_grid_container
branch
from
July 16, 2026 18:17
88b515c to
91bb5da
Compare
Member
|
I'll give this a proper try once rebased, sounds like a nice fix based on the description. |
mubinulhaque
force-pushed
the
user_settings_ui_grid_container
branch
2 times, most recently
from
August 3, 2026 10:49
9d6f993 to
c60e2f2
Compare
Contributor
Author
|
Rebased! |
mubinulhaque
force-pushed
the
user_settings_ui_grid_container
branch
from
August 3, 2026 10:52
c60e2f2 to
3e1929c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To decrease the amount of nodes, and to make creating new settings easier, I have replaced the several
HBoxContainerswith a singleGridContainerper section. I have also changed theLabels for the Apply buttons to "Save" instead, which is more in line with what these buttons do.Testing
The Main Menu scene had no issues not present in
master.Disclaimer
No generative AI was used to enhance or create the code given here.