Skip to content

Better format and static type Player Body - #871

Open
mubinulhaque wants to merge 1 commit into
GodotVR:masterfrom
mubinulhaque:player_body_formatting
Open

mubinulhaque wants to merge 1 commit into
GodotVR:masterfrom
mubinulhaque:player_body_formatting

Conversation

@mubinulhaque

Copy link
Copy Markdown
Contributor

In accordance with style guide given here:

  • Remove space between variable names and colons whenever types must be specified
  • Remove types whenever inferring is possible
  • Reorder functions in accordance with the style guide above
  • Clarify comments of variables and methods
  • Format multiline statements for better readability
  • Add suffixes to five export variables
  • Add return types to eleven methods
  • Add types to signal parameters
  • Add type to Dictionary and Array
  • Add BBCode to class doc
  • Replace exclamation marks with not keyword
  • Add types to for loop variables
  • Replace emit(signal, Callable) with signal.emit(Callable)

Testing

The Main Menu scene and the Basic Movement demo had no issues not present in master.

Disclaimer

No generative AI was used to enhance or create the code given here.

@BastiaanOlij BastiaanOlij added the cleanup Cleaning up code or aligning Godot 3 and 4 versions label Aug 2, 2026
@BastiaanOlij BastiaanOlij added this to the 4.6.0 milestone Aug 2, 2026
@BastiaanOlij

Copy link
Copy Markdown
Member

CI is still failing on a two long line issue.

@mubinulhaque

Copy link
Copy Markdown
Contributor Author

Considering how long this script is, would it be fine to add a gdlint-ignore for this, or should I try to shorten it?

@mubinulhaque mubinulhaque reopened this Sep 16, 2026
@mubinulhaque
mubinulhaque force-pushed the player_body_formatting branch 2 times, most recently from 649536a to da91a5d Compare September 16, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Cleaning up code or aligning Godot 3 and 4 versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants