Better format and static type Player Body - #871
Open
mubinulhaque wants to merge 1 commit into
Open
mubinulhaque wants to merge 1 commit into
mubinulhaque wants to merge 1 commit into
Conversation
Member
|
CI is still failing on a two long line issue. |
Contributor
Author
|
Considering how long this script is, would it be fine to add a gdlint-ignore for this, or should I try to shorten it? |
mubinulhaque
force-pushed
the
player_body_formatting
branch
from
September 16, 2026 11:03
cc491e1 to
ea87b7f
Compare
mubinulhaque
force-pushed
the
player_body_formatting
branch
from
September 16, 2026 11:05
ea87b7f to
a3826dd
Compare
mubinulhaque
force-pushed
the
player_body_formatting
branch
2 times, most recently
from
September 16, 2026 11:24
649536a to
da91a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with style guide given here:
DictionaryandArraynotkeywordforloop variablesemit(signal, Callable)withsignal.emit(Callable)Testing
The Main Menu scene and the Basic Movement demo had no issues not present in
master.Disclaimer
No generative AI was used to enhance or create the code given here.