Skip to content

added reward for payer config - #14

Open
LUK3ARK wants to merge 1 commit into
GlassEaters:mainfrom
LUK3ARK:feature/luk3-touch-up
Open

added reward for payer config#14
LUK3ARK wants to merge 1 commit into
GlassEaters:mainfrom
LUK3ARK:feature/luk3-touch-up

Conversation

@LUK3ARK

@LUK3ARK LUK3ARK commented Mar 13, 2022

Copy link
Copy Markdown

Not finished:

  1. finish Implementing transaction fee in calculation
  2. actually test

@vercel

vercel Bot commented Mar 13, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/glasseaters/hydra-dox/9EUipRVFGsWFN2FTBB8jh7736pXh
✅ Preview: https://hydra-dox-git-fork-luk3ark-feature-luk3-touch-up-glasseaters.vercel.app

@LUK3ARK

LUK3ARK commented Mar 13, 2022

Copy link
Copy Markdown
Author

Also add error code for when ATA should be supplied but is not

@austbot

austbot commented Mar 19, 2022

Copy link
Copy Markdown
Contributor

This is pretty cool, i'm going through it now.

@LUK3ARK

LUK3ARK commented Mar 19, 2022

Copy link
Copy Markdown
Author

See, I’m not just a pretty face 😃 just can’t find anything about computing the transaction fee on chain, and I don’t think it’s possible to allow someone to just input it because they can lie

@LUK3ARK

LUK3ARK commented Mar 19, 2022

Copy link
Copy Markdown
Author

I am aware I have error in distribute for wallet function it was added to test you out ofc

@staccDOTsol

Copy link
Copy Markdown
Collaborator

how's this coming along

@staccDOTsol

Copy link
Copy Markdown
Collaborator

@austbot can we just guess? ie. metaplex guess for arweave ;) ;)

plz, ser. there are nearly 2000 hydras. gib the power to the distbots

@staccDOTsol

Copy link
Copy Markdown
Collaborator

we probably don't care about the tx fee that the distributor pays? that's on them to guesstimate with preflight, and then judge for themselves whether a given distribution is worth it.

this creates competition for higher reward bp and also to distribute faster.

this is my wip

image

This was referenced May 5, 2022
Comment on lines +60 to +62
if payer_rewards > 0 {
if distribute_for_mint
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete?

Comment on lines +30 to +32
if payer_reward_basis_points == 0 {
Ok(0)
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woudln't this just work anyways since it would multiply by 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants