Post live deployment notifications to the "Create/Cut release and deploy" issue instead of the commit-derived issue - #1061
Open
balagan73 wants to merge 1 commit into
Conversation
AronNovak
reviewed
Jul 2, 2026
AronNovak
left a comment
Member
There was a problem hiding this comment.
Looks good, the usual way for such improvements is to test-drive at a client project, if it turns to be useful and robust, we can port it to DS. The latestreleaseissue seems to be fragile for me. It would be great to somehow robustly link an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1060
Summary
deployNotify()would fail to find (or find the wrong) issue to comment on.deployFindLatestReleaseIssue(), which looks up the latest open GitHub issue whose title starts with "Create release" or "Cut release" (case-insensitive, tolerant of trailing text like "and deploy", "& deploy", or a[2h]timebox suffix).deployNotify()now uses this lookup first when$pantheon_environment === 'live'; if no matching issue is found, it falls back unchanged to the existing commit-message/PR-based logic. QA and test environments are unaffected.Test plan
ddev phpcs robo-components/DeploymentTrait.php— no violationsddev phpstan analyse robo-components/DeploymentTrait.php— no errorsdeployFindLatestReleaseIssue()against real repos: returns correct issue numberdeployNotify('live')end-to-end in a temporary dry-run (print instead of POST) against another repo with deployment issue, confirming it targets real issue and composes the expected comment body🤖 Generated with Claude Code
TB: 1/1h