fix: harden CI permissions and triage CodeQL alerts - #38
Conversation
Limit build-only CI tokens to read-only contents permissions. Clarify intentional control filtering without changing signed post text, and replace the sitemap test hostname-prefix check with exact origins. Cover the image-preview React attribute boundary without changing its runtime behavior or dismissing the existing scanner warning.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (6)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe changes add workflow permission coverage and expand tests for image previews, post normalization and signing, and sitemap URL origins. ChangesCI permission coverage
Application validation coverage
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The reviewed CI permission, normalization, sitemap, and image-preview test changes introduce no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
A small CodeQL triage and hardening pass against current
main, kept separate from the UI/watchlist work in #34. No dependencies, contract behavior, upload behavior or wallet-signature formats change.contents: readtoken permissions, with a regression check.Alert-by-alert scope
img.src, not an HTML sink. The render tests support a false-positive assessment at this location, but do not constitute a browser/upload security audit. The alert is intentionally left undismissed.The old
posts.tscontains literal NUL/control bytes, so Git may show a binary diff.git diff --textshows the single regex-line replacement.Validation
532b5eb:launch-machine.test.tsassumes LF line endings, andwallet-picker.test.tsuses URL.pathname as a Windows filesystem path. No unrelated fixes are included.