feat(diff-filter): ignore Anchor's .anchor/ generated directory (#67)#132
Open
ouwibo wants to merge 1 commit into
Open
feat(diff-filter): ignore Anchor's .anchor/ generated directory (#67)#132ouwibo wants to merge 1 commit into
ouwibo wants to merge 1 commit into
Conversation
…unty#67) Adds .anchor/ to GENERATED_DIR_PREFIXES so anchor build / anchor test ledger artifacts and IDL cache files are filtered out of the diff sent to the reviewer, improving signal-to-noise on Solana PR reviews. Tests cover top-level, nested, and IDL-cache paths.
|
Someone is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #67. Adds
.anchor/toGENERATED_DIR_PREFIXESinpackages/diff-filterso the Anchor framework's ledger artifacts and IDL cache files are filtered out of the diff sent to the reviewer.Changes
packages/diff-filter/src/patterns.ts— add".anchor/"toGENERATED_DIR_PREFIXES(placed in the dot-prefixed cluster, conceptually adjacent totarget/which is Cargo's analog).packages/diff-filter/tests/classify.test.ts— extend thegenerated dirsdescribe block with three.anchor/cases: top-level, nested (the exact example from the issue), and an IDL JSON file.Acceptance criteria
classifyPathreturns{ ignore: true, reason: "generated_dir" }for.anchor/paths (top-level and nested)..anchor/path (added three).pnpm typecheck(7/7 packages) andpnpm testworkspace-wide (apps/mcp 54, relayer 243, frontend 217, diff-filter 71 — all green).Test plan
pnpm --filter @ghbounty/diff-filter test— 71 passedpnpm typecheck— all packages passpnpm test— full workspace green