build: Swapping NPM for PNPM Step 5 of 5 by scotttjob · Pull Request #3043 · GetJobber/atlantis

scotttjob · 2026-04-06T16:01:36Z

Motivations

We've long wanted to explore pnpm, and between some of the new features they're rolling out, the fact that Storybook is embracing it fully, and some of our internal packages have as well.
This PR Chain is in 5 steps, to make it easier to review.
This last PR is cleaning up the CI steps and trying to get everything back to a running state in CI.

Testing

This should pass CI.

Changes can be
tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

cloudflare-workers-and-pages · 2026-04-08T13:43:01Z

Deploying atlantis with Cloudflare Pages

Latest commit:	`94e61dc`
Status:	🚫 Build failed.

View logs

MichaelParadis · 2026-04-10T15:06:53Z

I did a build diff manually. This is the summary from Claude. I think the interesting one to look at is the restyled library
NOTE: - Menu/Menu.types.d.ts — Placement type is now derived from AriaPopoverProps["placement"] instead of @react-types/overlays was done by me to fix a type error while installing

Dist Changes Summary

All 240 changed files are in generated dist/ output — no source files are modified. This looks like a rebuild of the packages after several source-level changes.

1. Build tooling migration: `npm` → `pnpm` (1 file)

packages/components-native/dist/package.json

Scripts (build, bootstrap, prepack) were updated from npm run to pnpm run. Also includes dependency updates:

Storybook bumped from 9.1.x → 10.3.x
New dev deps added: @babel/runtime, @types/jest, @types/node, vite, @storybook/addon-mcp
New peer dep: @jobber/hooks >=2
react and react-test-renderer pinned to exact 19.1.1

2. TypeScript config changes (2 files)

packages/components-native/dist/tsconfig.json

Added "node" to the types array
Removed *.test.ts and *.test.tsx from the exclude list (tests are now excluded from the tsconfig differently)
tsconfig.build.tsbuildinfo regenerated as a result

3. Type definition changes — simplified/refactored return types (6 files)

packages/components/dist/

Autocomplete/useAutocomplete.d.ts — large inline return type replaced with a reference to the new UseAutocompleteProps interface
Autocomplete/Autocomplete.types.d.ts — new UseAutocompleteProps interface exported (consolidates the Autocomplete hook's return shape)
InputText/InputText.d.ts — heavily simplified; verbose inline overload union type reduced significantly
Modal/useModal.d.ts — UseModalProps renamed to UseModalOptions; return type now references ModalContextType instead of inlining all floating-ui types
Menu/Menu.types.d.ts — Placement type is now derived from AriaPopoverProps["placement"] instead of @react-types/overlays
Menu/Menu.d.ts — Menu.Item ref type tightened from object to HTMLDivElement

packages/components-native/dist/

BottomSheetKeyboardAwareScrollView.d.ts — new mode prop added; ScrollViewComponent type updated to use AnimatedScrollViewComponent from react-native-keyboard-controller

packages/hooks/dist/

useOnKeyDown/useOnKeyDown.d.ts — ts-xor dependency removed; XOR<VerboseKeyComparator, SimpleKeyComparator> replaced with native VerboseKeyComparator | SimpleKeyComparator

4. `reselect` library inlined into bundle (2 files)

packages/components/dist/unstyledPrimitives/index.mjs and index.cjs

The reselect package import was removed and its full source (~430 lines) was bundled directly, including dev-mode checks (runIdentityFunctionCheck, runInputStabilityCheck). This is the source of most of the +6126 / -5431 line delta.

5. CJS variable shadowing fix (across `packages/hooks/dist/`)

useCollectionQuery-cjs.js, useFocusTrap-cjs.js, and others

Internal bundled IIFE functions renamed exports → exports$1 to avoid variable shadowing in the CJS bundle output.

6. CSS formatting changes (1 file)

packages/components/dist/styles.css

Minor formatter/minifier output normalization — multi-line transition and gap/grid-gap declarations collapsed to single lines. No behavioral changes.

7. Re-bundled JS output for ~220 component files

The vast majority of files (-es.js, -cjs.js, .mjs, .cjs) across packages/components/dist/ are re-generated bundle output resulting from the above changes (updated imports, re-exported symbol reordering, etc.). For example, Button-es.js has its two named exports swapped in order — a cosmetic bundler output change with no functional impact.

MichaelParadis · 2026-04-10T15:09:06Z

packages/components/src/DataList/__tests__/DataList.utils.test.tsx

+        {
+          "$$typeof": Symbol(react.transitional.element),
+          "_owner": null,
+          "_store": {},
+          "key": null,
+          "props": {
+            "children": "Hello",
+            "level": 5,
+          },
+          "type": [Function],
+        }


At a complete glance this seems super odd to me. I am interested to know what caused this

Possibly this other pr in the chain?

https://github.com/GetJobber/atlantis/pull/3040/changes#diff-f89f4416027795670a5c4d72a35923b008d24f176d95a8f515f0976a4c8fed2b

updating circle to support pnpm

7435b7f

scotttjob changed the title ~~updating circle to support pnpm~~ build: Swapping NPM for PNPM Step 4 of 5 Apr 6, 2026

scotttjob changed the title ~~build: Swapping NPM for PNPM Step 4 of 5~~ build: Swapping NPM for PNPM Step 5 of 5 Apr 6, 2026

swapping to something closer to whats in another project

d20a33b

scotttjob added 9 commits April 8, 2026 10:47

trying without the latest

3fb3552

following the pnpm docs

6ab82b7

trying out something different

904bbf4

trying out something different

fc78a98

got another run

9068ad1

e2e passing

b8cda1e

trying to get ci running

f8733eb

updating lockfile

b8f0f07

another round of ci

94e61dc

MichaelParadis reviewed Apr 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Swapping NPM for PNPM Step 5 of 5#3043

build: Swapping NPM for PNPM Step 5 of 5#3043
scotttjob wants to merge 11 commits intoscott_t/pnpm-upgrade-chain-4from
scott_t/pnpm-upgrade-chain-5

scotttjob commented Apr 6, 2026

Uh oh!

cloudflare-workers-and-pages bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

MichaelParadis commented Apr 10, 2026 •

edited

Loading

Uh oh!

MichaelParadis Apr 10, 2026

Uh oh!

scotttjob Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

scotttjob commented Apr 6, 2026

Motivations

Testing

Uh oh!

cloudflare-workers-and-pages bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying atlantis with Cloudflare Pages

Uh oh!

MichaelParadis commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dist Changes Summary

1. Build tooling migration: npm → pnpm (1 file)

2. TypeScript config changes (2 files)

3. Type definition changes — simplified/refactored return types (6 files)

4. reselect library inlined into bundle (2 files)

5. CJS variable shadowing fix (across packages/hooks/dist/)

6. CSS formatting changes (1 file)

7. Re-bundled JS output for ~220 component files

Uh oh!

MichaelParadis Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

scotttjob Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

cloudflare-workers-and-pages bot commented Apr 8, 2026 •

edited

Loading

MichaelParadis commented Apr 10, 2026 •

edited

Loading

1. Build tooling migration: `npm` → `pnpm` (1 file)

4. `reselect` library inlined into bundle (2 files)

5. CJS variable shadowing fix (across `packages/hooks/dist/`)