Skip to content

build: Swapping NPM for PNPM Step 3 of 5#3041

Draft
scotttjob wants to merge 1 commit intoscott_t/pnpm-upgrade-chain-2from
scott_t/pnpm-upgrade-chain-3
Draft

build: Swapping NPM for PNPM Step 3 of 5#3041
scotttjob wants to merge 1 commit intoscott_t/pnpm-upgrade-chain-2from
scott_t/pnpm-upgrade-chain-3

Conversation

@scotttjob
Copy link
Copy Markdown
Contributor

Motivations

  1. We've long wanted to explore pnpm, and between some of the new features they're rolling out, the fact that Storybook is embracing it fully, and some of our internal packages have as well.
  2. This PR Chain is in 5 steps, to make it easier to review.
  3. This third PR is making upgrading Storybook 9 -> 10, and integrating Storybook MCP.
  4. This PR is not technically required as part of this chain to upgrade to pnpm, but it was the original spark for the work, which is why it's here.
  5. If we decide to instead cherry pick these changes against master instead, that's fine with me!

Changes

  1. Migrating to Storybook 10 in both repos.
  2. Adding Storybook MCP
  3. Some changes to get everything building.

Changes can be
tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

@@ -0,0 +1,194 @@
[10:57:37.481] [INFO] Storybook upgrade - v10.3.3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to commit this

@@ -0,0 +1,253 @@
[10:59:31.920] [INFO] Storybook upgrade - v10.3.3
[10:59:31.921] [INFO] detect-projects-spinner-start: Detecting projects...
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you meant to commit this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants