chore: configure v6 branch for maintenance releases [JOB-145516]#3038
chore: configure v6 branch for maintenance releases [JOB-145516]#3038
Conversation
Made-with: Cursor
Deploying atlantis with
|
| Latest commit: |
399d0f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ffa3e039.atlantis.pages.dev |
| Branch Preview URL: | https://job-145516-adjust-npm-releas.atlantis.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR attempts to configure the repository for v6 maintenance releases while master moves to v7+. The changes modify core release configuration files to scope lerna to specific packages, restrict releases to the v6 branch only, and add a new CircleCI workflow for v6 releases.
Changes:
- Modified
lerna.jsonto scope packages to 4 specific packages (components, design, hooks, formatters) and set release restrictions to v6 branch only - Added
ci:release-v6script topackage.jsonfor patch-only releases with v6 dist-tag - Added
release_v6CircleCI job and workflow that mirrors the existing release workflow but targets the v6 branch
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lerna.json | Scopes to 4 JO-relevant packages, restricts releases to v6 branch, disables workspaces |
| package.json | Adds ci:release-v6 script for v6 patch releases |
| .circleci/config.yml | Adds release_v6 job and workflow configuration for v6 branch releases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "allowBranch": [ | ||
| "master" | ||
| "v6" | ||
| ] |
There was a problem hiding this comment.
The allowBranch is set to only ["v6"], which will prevent releases on the master branch. If this PR is being merged to master, the master branch will be unable to publish releases. The allowBranch should remain as ["master"] on the master branch. These v6-specific configuration changes should only be applied to the v6 branch itself, not to master.
There was a problem hiding this comment.
This PR is into the v6 branch. The v6 branch will/should NEVER be merged into master.
| "packages": [ | ||
| "packages/*" | ||
| "packages/components", | ||
| "packages/design", | ||
| "packages/hooks", | ||
| "packages/formatters" | ||
| ], |
There was a problem hiding this comment.
The packages list has been changed from "packages/*" (which includes all 11 packages) to only 4 packages: components, design, hooks, and formatters. This excludes components-native, docx, eslint-config, generators, site, and stylelint-config. If this is intended for the v6 branch only, this change will affect master and prevent releases of those excluded packages. On master, this should remain as "packages/*" to ensure all packages can be managed by lerna.
There was a problem hiding this comment.
master remains the same. These changes WILL NOT be merged to master.
| } | ||
| }, | ||
| "useWorkspaces": true | ||
| "useWorkspaces": false |
There was a problem hiding this comment.
The useWorkspaces setting has been changed from true to false. This is a significant configuration change that could affect how lerna manages dependencies across the monorepo. If this is intended for the v6 branch only, it should not be applied to master, as the main branch still uses workspaces (as defined in package.json lines 6-17). On master, this should remain as true.
| "version": { | ||
| "conventionalCommits": true, | ||
| "message": "chore(release): Publish", | ||
| "message": "chore(release): Publish v6", |
There was a problem hiding this comment.
The release commit message has been changed from "chore(release): Publish" to "chore(release): Publish v6". This will affect how the release detection works for the master branch. The check_for_manual_release job (.circleci/config.yml line 103) looks for "chore(release): Publish", which will no longer match on master if this change is applied there. The release message should be changed back to "chore(release): Publish" for master to maintain compatibility.
Motivations
Sets up the
v6branch for long-lived maintenance releases to support JO whilemastermoves to v7+.Part of JOB-145516.
Changes
Changed
lerna.json: scoped to 4 JO-relevant packages (components,design,hooks,formatters), setallowBranchtov6, setuseWorkspaces: false, changed release commit message to"chore(release): Publish v6"package.json: addedci:release-v6script that forces patch-only bumps with--dist-tag v6.circleci/config.yml: addedrelease_v6job and workflow entry (mirrors existingreleasebut runs onv6branch, publishes underv6dist-tag)Testing
These are config-only changes (lerna.json, package.json, CircleCI). No runtime code is affected.
Already verified locally:
npx lerna lson this branch lists only the 4 scoped packages (components, design, hooks, formatters) - confirmed workingAfter merging:
v6(e.g., a comment in a component file)release_v6CircleCI job - it should publish a patch version under thev6dist-tagnpm view @jobber/components dist-tags- a newv6entry should appear