Skip to content

chore: configure v6 branch for maintenance releases [JOB-145516]#3038

Open
nad182 wants to merge 1 commit intov6from
JOB-145516/adjust-npm-release-process-v6-support
Open

chore: configure v6 branch for maintenance releases [JOB-145516]#3038
nad182 wants to merge 1 commit intov6from
JOB-145516/adjust-npm-release-process-v6-support

Conversation

@nad182
Copy link
Copy Markdown
Contributor

@nad182 nad182 commented Apr 6, 2026

Motivations

Sets up the v6 branch for long-lived maintenance releases to support JO while master moves to v7+.

Part of JOB-145516.

Changes

Changed

  • lerna.json: scoped to 4 JO-relevant packages (components, design, hooks, formatters), set allowBranch to v6, set useWorkspaces: false, changed release commit message to "chore(release): Publish v6"
  • package.json: added ci:release-v6 script that forces patch-only bumps with --dist-tag v6
  • .circleci/config.yml: added release_v6 job and workflow entry (mirrors existing release but runs on v6 branch, publishes under v6 dist-tag)

Testing

These are config-only changes (lerna.json, package.json, CircleCI). No runtime code is affected.

Already verified locally:

  • npx lerna ls on this branch lists only the 4 scoped packages (components, design, hooks, formatters) - confirmed working

After merging:

  1. Merge a trivial code change to v6 (e.g., a comment in a component file)
  2. Watch the release_v6 CircleCI job - it should publish a patch version under the v6 dist-tag
  3. Verify with npm view @jobber/components dist-tags - a new v6 entry should appear

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 399d0f0
Status: ✅  Deploy successful!
Preview URL: https://ffa3e039.atlantis.pages.dev
Branch Preview URL: https://job-145516-adjust-npm-releas.atlantis.pages.dev

View logs

@nad182 nad182 requested a review from Copilot April 8, 2026 19:54
@nad182 nad182 marked this pull request as ready for review April 8, 2026 19:54
@nad182 nad182 requested a review from a team as a code owner April 8, 2026 19:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to configure the repository for v6 maintenance releases while master moves to v7+. The changes modify core release configuration files to scope lerna to specific packages, restrict releases to the v6 branch only, and add a new CircleCI workflow for v6 releases.

Changes:

  • Modified lerna.json to scope packages to 4 specific packages (components, design, hooks, formatters) and set release restrictions to v6 branch only
  • Added ci:release-v6 script to package.json for patch-only releases with v6 dist-tag
  • Added release_v6 CircleCI job and workflow that mirrors the existing release workflow but targets the v6 branch

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
lerna.json Scopes to 4 JO-relevant packages, restricts releases to v6 branch, disables workspaces
package.json Adds ci:release-v6 script for v6 patch releases
.circleci/config.yml Adds release_v6 job and workflow configuration for v6 branch releases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 13 to 15
"allowBranch": [
"master"
"v6"
]
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allowBranch is set to only ["v6"], which will prevent releases on the master branch. If this PR is being merged to master, the master branch will be unable to publish releases. The allowBranch should remain as ["master"] on the master branch. These v6-specific configuration changes should only be applied to the v6 branch itself, not to master.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is into the v6 branch. The v6 branch will/should NEVER be merged into master.

Comment on lines 3 to 8
"packages": [
"packages/*"
"packages/components",
"packages/design",
"packages/hooks",
"packages/formatters"
],
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages list has been changed from "packages/*" (which includes all 11 packages) to only 4 packages: components, design, hooks, and formatters. This excludes components-native, docx, eslint-config, generators, site, and stylelint-config. If this is intended for the v6 branch only, this change will affect master and prevent releases of those excluded packages. On master, this should remain as "packages/*" to ensure all packages can be managed by lerna.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master remains the same. These changes WILL NOT be merged to master.

}
},
"useWorkspaces": true
"useWorkspaces": false
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useWorkspaces setting has been changed from true to false. This is a significant configuration change that could affect how lerna manages dependencies across the monorepo. If this is intended for the v6 branch only, it should not be applied to master, as the main branch still uses workspaces (as defined in package.json lines 6-17). On master, this should remain as true.

Copilot uses AI. Check for mistakes.
"version": {
"conventionalCommits": true,
"message": "chore(release): Publish",
"message": "chore(release): Publish v6",
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release commit message has been changed from "chore(release): Publish" to "chore(release): Publish v6". This will affect how the release detection works for the master branch. The check_for_manual_release job (.circleci/config.yml line 103) looks for "chore(release): Publish", which will no longer match on master if this change is applied there. The release message should be changed back to "chore(release): Publish" for master to maintain compatibility.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants