Skip to content

refactor: DO NOT MERGE - Exploration Menu Round 2#3021

Draft
scotttjob wants to merge 3 commits intomasterfrom
scott_t/menu-exploration-2
Draft

refactor: DO NOT MERGE - Exploration Menu Round 2#3021
scotttjob wants to merge 3 commits intomasterfrom
scott_t/menu-exploration-2

Conversation

@scotttjob
Copy link
Copy Markdown
Contributor

Motivations

  1. Further exploration around Menu and the new shape of components within Atlantis.
  2. This is still a bit rough around the edges, still needs to be gone through with a fine-toothed comb, and compared against actual designs (Julia has a PR which has that completed).
  3. Biggest change is around the Trigger pattern. We're now using the Menu.Trigger pattern again, with a render prop option.

Testing

  1. DO NOT MERGE. Draft Only.

What's left to do

Still need to make sure all the patterns are intact. I don't think private/primitives is set up properly yet.

Still need to make sure this lines up with design.

Changes can be
tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 31, 2026

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff81140
Status: ✅  Deploy successful!
Preview URL: https://634b7a92.atlantis.pages.dev
Branch Preview URL: https://scott-t-menu-exploration-2.atlantis.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant