fix(models): support max thinking effort

[barbatdev]

Closes #286

Summary

• Add max to the ordered thinking-effort vocabulary used by /gentle:models.
• Derive the TypeScript type, picker options, and runtime validator from one source of truth.
• Preserve thinking: "max" through normalization and emit it as effort: "max" in generated subagent profiles.

Changes

File	Change
extensions/gentle-ai.ts	Centralize thinking levels and add max after xhigh.
tests/runtime-harness.mjs	Cover picker selection and config-to-subagents/frontmatter propagation.

Test plan

• pnpm run test:harness
• node --experimental-strip-types --test tests/gentle-ai.test.ts
• Independent verification passed.
• Native four-lens review completed without findings.
• Pre-commit, pre-push, and pre-PR gates validated the reviewed candidate.

PR type

• Bug fix
• New feature
• Documentation only
• Code refactoring
• Maintenance/tooling
• Breaking change

Contributor checklist

• Linked an approved issue.
• Uses one type:* label.
• Tests are included with the behavior change.
• Documentation is unchanged because the README does not enumerate effort levels.
• Commit follows Conventional Commits.
• No AI attribution or co-author trailer.

Out of scope

Provider-specific effort filtering remains the runtime responsibility.

Summary by CodeRabbit

• New Features

  • Added Max as a thinking-level option.
  • Model-routing configurations can now save and apply the Max effort level.
  • The effort picker includes Max after the Extra High option.

• Bug Fixes

  • Fixed persistence of the Max thinking level across model-routing settings and agent configurations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 479519b8-4f54-4418-b217-50338fa3da67

📥 Commits

Reviewing files that changed from the base of the PR and between 19b0ed7 and 98af033.

📒 Files selected for processing (2)

• extensions/gentle-ai.ts
• tests/runtime-harness.mjs

---

📝 Walkthrough

Walkthrough

The change adds max as a supported thinking level, derives picker options and validation from one shared tuple, and adds runtime coverage for configuration, subagent profiles, agent frontmatter, and picker interactions.

Changes

Thinking level support

Layer / File(s)	Summary
Centralize max thinking-level support extensions/gentle-ai.ts	The shared thinking-level tuple includes max and drives picker options and validation.
Validate max persistence tests/runtime-harness.mjs	Runtime tests verify max persistence in global configuration, subagent profiles, agent frontmatter, and the effort picker.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 98af0

This localized change adds support for the max thinking effort and propagates it through generated profiles; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• Gentleman-Programming/gentle-pi#76: Changes the same extension and runtime harness, but addresses orchestrator prompt loading.

Suggested reviewers: alan-thegentleman

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: adding support for the max thinking effort.
Linked Issues check	✅ Passed	The changes add, preserve, validate, and propagate max thinking effort as required by issue #286.
Out of Scope Changes check	✅ Passed	All code and test changes directly support max thinking effort handling and issue #286 requirements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}