Problem
upstream/main deterministically fails the restart-parity test because its worker fixture calls executeReviewControllerOperation with a stale positional argument layout.
The fixture passes new Map() as the third argument and the native client as the fourth argument. The current controller signature expects the native client as the third argument, so FINALIZE receives a Map instead of the stubbed native client and exits as native-status-unsupported before invoking the relay.
Reproduction
On upstream/main at 54f691cd9c2b636210823e9a3e7dcf0bd3b1c2dc:
node --experimental-strip-types --test tests/review-host-relay-restart-parity.test.ts
Run three times, the command failed identically three times with 0 passed and 3 failed. The first assertion observed zero relay requests instead of one.
Expected behavior
The worker passes its native stub to the controller's nativeReviewCli parameter. All three restart-parity scenarios reach the relay path and pass.
Actual behavior
The controller receives new Map() as nativeReviewCli, cannot find targetStatus, and returns a blocked native-status-unsupported envelope. The relay runner, provider status stub, and native finalize stub are never called.
Root cause
Current fixture call:
executeReviewControllerOperation(parameters, cwd, new Map(), nativeReviewCli)
Current controller signature begins with:
(parametersValue, sessionCwd, nativeReviewCli, signal?, candidateViews?, ...)
The positional call was not updated when the controller signature changed.
Acceptance criteria
Scope
This is a regression in the P6 test fixture introduced under #311. Issue #311 is already closed, and open issue #377 covers Pi runtime identity rather than this stale fixture signature.
Evidence
Problem
upstream/maindeterministically fails the restart-parity test because its worker fixture callsexecuteReviewControllerOperationwith a stale positional argument layout.The fixture passes
new Map()as the third argument and the native client as the fourth argument. The current controller signature expects the native client as the third argument, so FINALIZE receives aMapinstead of the stubbed native client and exits asnative-status-unsupportedbefore invoking the relay.Reproduction
On
upstream/mainat54f691cd9c2b636210823e9a3e7dcf0bd3b1c2dc:Run three times, the command failed identically three times with 0 passed and 3 failed. The first assertion observed zero relay requests instead of one.
Expected behavior
The worker passes its native stub to the controller's
nativeReviewCliparameter. All three restart-parity scenarios reach the relay path and pass.Actual behavior
The controller receives
new Map()asnativeReviewCli, cannot findtargetStatus, and returns a blockednative-status-unsupportedenvelope. The relay runner, provider status stub, and native finalize stub are never called.Root cause
Current fixture call:
Current controller signature begins with:
The positional call was not updated when the controller signature changed.
Acceptance criteria
tests/review-host-relay-restart-parity.test.tspasses all three scenarios.Scope
This is a regression in the P6 test fixture introduced under #311. Issue #311 is already closed, and open issue #377 covers Pi runtime identity rather than this stale fixture signature.
Evidence