fix(codegraph): add injectable shell-free runner - #163
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe CodeGraph runner is now created through an injectable factory, forwards execution options to ChangesCodeGraph runner execution
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant createCodeGraphTool
participant runCodeGraphCommand
participant execFile
createCodeGraphTool->>runCodeGraphCommand: execute with cwd, signal, maxBuffer
runCodeGraphCommand->>execFile: run command without shell wrapping
execFile-->>runCodeGraphCommand: stdout and stderr or error
runCodeGraphCommand-->>createCodeGraphTool: output or failure details with args
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The dependent Windows slice is now available as a clean fork-local Draft: MarsSall#1 It targets this PR's branch, so reviewers can inspect only the 234-line follow-up. After #163 merges, the same reviewed branch will be proposed to |
Summary
cwd, cancellation signals, and output-buffer limits.Part of #160. The follow-up PR will add the Windows npm-entry resolution and close the issue.
Changes
extensions/codegraph-tools.tstests/codegraph-tools.test.tsTest plan
node --experimental-strip-types --test tests/codegraph-tools.test.ts— 14/14 passing on the completed stack.git diff --checkpassed.Chain Context
mainfix/windows-codegraph-npm-entryafter this PR mergesmainat1fbaf829Chain Overview
Scope
Autonomy
Contributor checklist
Co-Authored-Bytrailer.type:*label after PR creation.Summary by CodeRabbit
Bug Fixes
Tests