Skip to content

feat(review)!: make approval terminal and burn lineage #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alan-TheGentleman merged 3 commits into from
Aug 21, 2026
Merged

feat(review)!: make approval terminal and burn lineage #3536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b43e092
feat(review)!: make approval terminal and burn lineage
Alan-TheGentleman Aug 21, 2026
3c3b8a0
fix(review): complete atomic lifecycle integration
Alan-TheGentleman Aug 21, 2026
a99d33f
test(review): align Windows acceptance with terminal burn
Alan-TheGentleman Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 0 additions & 7 deletions .deadcode-baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal/catalog/agents.go MVPAgents
internal/cli/doctor.go checkToolBinaries
internal/cli/restore.go RunRestoreWithFn
internal/cli/restore.go RunRestoreWithFnAndInput
internal/cli/review_facade.go emitFacadeGateEvaluation
internal/cli/review_facade.go facadeFinalizeAttemptRequest
internal/cli/review_facade.go facadeFinalizeReplayRequestDigest
internal/cli/review_facade.go facadeValidationResult.native
Expand Down Expand Up @@ -64,8 +63,6 @@ internal/reviewtransaction/candidate_decline.go CandidateDeclineAuthorization.va
internal/reviewtransaction/candidate_decline.go candidateDeclineDigest
internal/reviewtransaction/candidate_decline.go canonicalCandidateDeclinePayload
internal/reviewtransaction/candidate_decline.go parseCandidateDeclineAuthorization
internal/reviewtransaction/candidate_relation.go shadowPushBoundaryUnresolvable
internal/reviewtransaction/candidate_relation.go shadowRelationHasNoLiveCounterpart
internal/reviewtransaction/compact_result_disposition.go CompactResultDispositionAuthorization
internal/reviewtransaction/gate.go hashArtifactSource
internal/reviewtransaction/gate.go hashLedgerArtifactSource
Expand Down Expand Up @@ -132,12 +129,8 @@ internal/reviewtransaction/rar_windows_owner_trust.go rarWindowsRepairOwnerContr
internal/reviewtransaction/rdd_mode.go AuthorizeRDDCandidate
internal/reviewtransaction/receipt_ref.go strictDecodeSDDReceiptRef
internal/reviewtransaction/repository_locator.go RepositoryIdentityLease.StorageKey
internal/reviewtransaction/repository_locator.go RepositoryIdentityLease.Validate
internal/reviewtransaction/repository_locator.go RepositoryIdentityLease.validateCapturedIdentity
internal/reviewtransaction/repository_locator.go locatorPathStrictlyWithin
internal/reviewtransaction/repository_locator.go repositoryIdentityChanged
internal/reviewtransaction/repository_locator.go resolveReviewRepositoryDirectory
internal/reviewtransaction/repository_locator.go validRepositoryIdentityLease
internal/reviewtransaction/risk.go deriveSemanticRiskSignals
internal/reviewtransaction/snapshot.go sanitizedGitEnvironment
internal/reviewtransaction/snapshot.go snapshotIdentity
Expand Down
29 changes: 7 additions & 22 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,14 @@ jobs:
[.journeys[] | select(.id == $id)] as $matches
| ($matches | length == 1) and ($matches[0].status == "completed");
completed_once("j51-negotiated-status-correction-continuation") and
completed_once("j52-sdd-stale-authority-does-not-shadow-approved-candidate") and
completed_once("j53-sdd-ambiguous-authorities-fail-closed") and
completed_once("j54-sdd-missing-authority-receipt-fails-closed") and
completed_once("j55-sdd-mismatched-authority-receipt-fails-closed") and
completed_once("j56-sdd-non-allow-post-apply-gate-fails-closed") and
completed_once("j58-sdd-foreign-openspec-path-fails-closed") and
completed_once("j104-repository-context-survives-fresh-process") and
completed_once("j59-current-status-and-start-ignore-sibling-worktree-transaction") and
completed_once("j60-explicit-active-lineage-keeps-four-lens-correction-and-validator-flow") and
completed_once("j75-intended-untracked-selection-executes-printed-start") and
completed_once("j81-rc1-consecutive-rescope-repair-executes-printed-command") and
completed_once("j75-intended-untracked-selection-executes-printed-start")
completed_once("j89-staged-validation-is-informational-and-unmanaged") and
completed_once("j104-repository-context-survives-fresh-process") and
completed_once("j110-untracked-terminal-burn-and-unmanaged-staged-validation") and
completed_once("j111-approved-transaction-burns-and-shipped-gates-are-unmanaged")
' "$RUNNER_TEMP/bench-portable.json"
"$RUNNER_TEMP/gentle-ai-bench" run --binary "$RUNNER_TEMP/gentle-ai" --only j105-compiled-provider-capture-retries-same-binding --out "$RUNNER_TEMP/bench-provider-capture.json"
jq -e '
Expand Down Expand Up @@ -112,13 +111,6 @@ jobs:
completed_once("tr10-scope-change-after-the-review-is-bound") and
completed_once("tr11-abandon-the-review-while-an-attempt-is-open")
' "$RUNNER_TEMP/bench-transition.json"
"$RUNNER_TEMP/gentle-ai-bench" run --binary "$RUNNER_TEMP/gentle-ai" --axis source-coupled --only j57-sdd-authority-drift-during-discovery-fails-closed --out "$RUNNER_TEMP/bench-source-coupled-untagged.json"
jq -e '
def unsupported_once($id):
[.journeys[] | select(.id == $id)] as $matches
| ($matches | length == 1) and ($matches[0].status == "unsupported");
unsupported_once("j57-sdd-authority-drift-during-discovery-fails-closed")
' "$RUNNER_TEMP/bench-source-coupled-untagged.json"
"$RUNNER_TEMP/gentle-ai-bench" run --binary "$RUNNER_TEMP/gentle-ai" --axis model-picker --only j97-opencode-custom-agent-model-picker-runtime --out "$RUNNER_TEMP/bench-model-picker-untagged.json"
jq -e '
def unsupported_once($id):
Expand All @@ -127,13 +119,6 @@ jobs:
unsupported_once("j97-opencode-custom-agent-model-picker-runtime")
' "$RUNNER_TEMP/bench-model-picker-untagged.json"
go build -tags bench_fixture -trimpath -o "$RUNNER_TEMP/gentle-ai-bench-fixture" ./cmd/gentle-ai
"$RUNNER_TEMP/gentle-ai-bench" run --binary "$RUNNER_TEMP/gentle-ai-bench-fixture" --axis source-coupled --only j57-sdd-authority-drift-during-discovery-fails-closed --out "$RUNNER_TEMP/bench-source-coupled.json"
jq -e '
def completed_once($id):
[.journeys[] | select(.id == $id)] as $matches
| ($matches | length == 1) and ($matches[0].status == "completed");
completed_once("j57-sdd-authority-drift-during-discovery-fails-closed")
' "$RUNNER_TEMP/bench-source-coupled.json"
"$RUNNER_TEMP/gentle-ai-bench" run --binary "$RUNNER_TEMP/gentle-ai-bench-fixture" --axis model-picker --only j97-opencode-custom-agent-model-picker-runtime --out "$RUNNER_TEMP/bench-model-picker.json"
jq -e '
def completed_once($id):
Expand Down
15 changes: 0 additions & 15 deletions .refusal-ratchet-baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ internal/cli/codegraph.go "unsafe CodeGraph root %q"
internal/cli/install.go "unexpected install argument %q"
internal/cli/restore.go "no backups available to restore"
internal/cli/restore.go "no confirmation provided (use --yes to skip prompt)"
internal/cli/review.go "authority lock is held by a concurrent review operation"
internal/cli/review.go "compact review receipts require native authority flags --lineage and --gate, not --request"
internal/cli/review.go "compact transport contains its receipt and does not accept legacy --receipt or --request ceremony"
internal/cli/review.go "legacy v1 review bundle import requires --request"
internal/cli/review.go "lineage exists in both compact and legacy stores; explicit cleanup is required"
Expand All @@ -13,9 +11,6 @@ internal/cli/review.go "review-bundle-import requires --cwd and --bundle"
internal/cli/review.go "review-resume requires --cwd and --lineage"
internal/cli/review.go "review-start requires --cwd, --lineage, and --policy-file"
internal/cli/review.go "review-step requires --cwd, --lineage, --operation, and --input"
internal/cli/review.go "review-validate --request mode cannot be combined with native request flags"
internal/cli/review.go "review-validate native mode requires --lineage and --gate"
internal/cli/review.go "review-validate requires --cwd and --receipt"
internal/cli/review.go "terminal review bundle import requires --receipt"
internal/cli/review.go "unexpected review-bundle-export argument %q"
internal/cli/review.go "unexpected review-bundle-import argument %q"
Expand Down Expand Up @@ -59,7 +54,6 @@ internal/cli/review_artifact.go "reviewer artifact is not an owner-only regular
internal/cli/review_artifact.go "reviewer artifact path changed before read"
internal/cli/review_artifact.go "reviewer artifact path changed during read"
internal/cli/review_artifact.go "reviewer result directory is not a private native directory"
internal/cli/review_artifact.go "reviewer result requires explicit findings and evidence arrays"
internal/cli/review_artifact.go "verify reviewer artifact %d: artifact manifest does not match the provider-owned subject"
internal/cli/review_capabilities.go "Go build version is unavailable"
internal/cli/review_capabilities.go "capability build identity is invalid"
Expand All @@ -85,7 +79,6 @@ internal/cli/review_facade.go "--workspace-overlay requires exactly one of --bas
internal/cli/review_facade.go "artifact exceeds the native result size limit"
internal/cli/review_facade.go "artifact manifest input must be a regular file"
internal/cli/review_facade.go "base-diff recovery requires matching --base-ref and --committed-only"
internal/cli/review_facade.go "compact authority %q already governs this lineage id for a different candidate: recover it into a successor first (fill in --successor-lineage and --disposition): %s ; or retry `review start` with a different --lineage to start independently"
internal/cli/review_facade.go "compact finalize transition did not match its planned revision"
internal/cli/review_facade.go "existing receipt cannot be read"
internal/cli/review_facade.go "existing receipt differs from terminal authority"
Expand All @@ -94,7 +87,6 @@ internal/cli/review_facade.go "input contains multiple JSON values"
internal/cli/review_facade.go "legacy review invalidation requires --reason"
internal/cli/review_facade.go "live low-risk projection no longer matches the frozen authority"
internal/cli/review_facade.go "multiple compact facade review lineages found; specify --lineage"
internal/cli/review_facade.go "multiple facade review lineages found; specify --lineage"
internal/cli/review_facade.go "native low-risk verification does not support target kind %q"
internal/cli/review_facade.go "negotiated base-diff START requires exactly --base-ref and --committed-only"
internal/cli/review_facade.go "negotiated current-changes START contains a partial base selector"
Expand All @@ -104,15 +96,13 @@ internal/cli/review_facade.go "negotiated review start requires an exact support
internal/cli/review_facade.go "negotiated review start requires exactly one --contract, --target, and --projection"
internal/cli/review_facade.go "negotiated workspace-overlay START requires exactly --base-ref and --workspace-overlay"
internal/cli/review_facade.go "no compact FINALIZE authority matches the live target"
internal/cli/review_facade.go "no discoverable facade review lineage found"
internal/cli/review_facade.go "pristine review invalidation requires --reason"
internal/cli/review_facade.go "receipt publication replay requires the exact explicit --lineage"
internal/cli/review_facade.go "receipt writer did not materialize the derived receipt"
internal/cli/review_facade.go "recovery base-ref does not match predecessor base"
internal/cli/review_facade.go "recovery scope has not changed"
internal/cli/review_facade.go "review %s repeats --%s"
internal/cli/review_facade.go "review authority is ambiguous across compact v2 and legacy v1 stores"
internal/cli/review_facade.go "review authority is ambiguous across compact v2 and legacy v1 stores; specify and clean up the intended lineage"
internal/cli/review_facade.go "review bind-sdd expected-binding-revision must be empty or sha256"
internal/cli/review_facade.go "review bind-sdd requires --cwd, --change, --lineage, and --expected-binding-revision"
internal/cli/review_facade.go "review finalize accepts exactly one reviewer-result source and one final-evidence source"
Expand Down Expand Up @@ -253,7 +243,6 @@ internal/cli/review_start_contract.go "negotiated START risk reasons are not can
internal/cli/review_start_contract.go "negotiated START risk reasons do not match the frozen tier"
internal/cli/review_start_contract.go "negotiated START selected lenses require frozen candidate context"
internal/cli/review_start_contract.go "negotiated overlay START target identity is incomplete"
internal/cli/review_start_contract.go "unsupported negotiated START action %q"
internal/cli/review_start_contract.go "unsupported negotiated START projection %q"
internal/cli/review_start_contract.go "unsupported negotiated START risk %q"
internal/cli/review_start_contract.go "unsupported negotiated START risk reason %q"
Expand Down Expand Up @@ -637,7 +626,6 @@ internal/reviewtransaction/compact_abandon.go "review abandon requires a non-emp
internal/reviewtransaction/compact_abandon.go "review abandon requires the exact current store revision"
internal/reviewtransaction/compact_batch_reconcile_journal.go "compact batch reconciliation is prepared; exact replay is required"
internal/reviewtransaction/compact_gate.go "committed approved target has dirty tracked changes"
internal/reviewtransaction/compact_gate.go "no committed base-diff recovery is derivable for this delivery"
internal/reviewtransaction/compact_gate.go "publication exclusion contains HEAD and would erase the publication range"
internal/reviewtransaction/compact_gate.go "publication merge %s must have exactly one merge base"
internal/reviewtransaction/compact_gate.go "publication merge %s must have exactly two parents"
Expand Down Expand Up @@ -753,7 +741,6 @@ internal/reviewtransaction/compact_store.go "imported compact authority does not
internal/reviewtransaction/compact_store.go "imported compact authority does not match the original base-to-final path scope"
internal/reviewtransaction/compact_store.go "imported compact record checksum changed"
internal/reviewtransaction/compact_store.go "initial compact snapshot is not repository-derived"
internal/reviewtransaction/compact_store.go "invalid compact authority graph: fork at %q"
internal/reviewtransaction/compact_store.go "invalid compact review state record"
internal/reviewtransaction/compact_store.go "invalid compact review transport"
internal/reviewtransaction/compact_store.go "legacy v1 review lineage is read-only"
Expand All @@ -778,7 +765,6 @@ internal/reviewtransaction/compact_store.go "reviewer result reopen does not car
internal/reviewtransaction/compact_store.go "reviewer result reopen lacks an exact predecessor authority"
internal/reviewtransaction/compact_store.go "scope-changed recovery requires an approved or correction-required predecessor"
internal/reviewtransaction/compact_store.go "staged workspace-overlay authority cannot be imported"
internal/reviewtransaction/compact_store.go "staged workspace-overlay authority requires approved recovery"
internal/reviewtransaction/compact_store.go "unsupported recovery disposition"
internal/reviewtransaction/final_verification_retry.go "final-verification incident contains an invalid SHA-256 binding"
internal/reviewtransaction/final_verification_retry.go "final-verification incident contains multiple JSON values"
Expand Down Expand Up @@ -1168,7 +1154,6 @@ internal/reviewtransaction/target_status.go "legacy target receipt does not equa
internal/reviewtransaction/target_status.go "non-terminal compact authority has a published receipt"
internal/reviewtransaction/target_status_projection.go "invalid compact authority graph: dangling predecessor for %q"
internal/reviewtransaction/target_status_projection.go "invalid compact authority graph: recovery cycle"
internal/reviewtransaction/target_status_projection.go "lineage %q has mixed compact and legacy authority"
internal/reviewtransaction/targeted_validation_request.go "targeted validation live snapshot uses a different correction projection"
internal/reviewtransaction/targeted_validation_request.go "targeted validation live snapshot uses a different intended-untracked set"
internal/reviewtransaction/targeted_validation_request.go "targeted validation request candidate tree is invalid"
Expand Down
15 changes: 4 additions & 11 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,10 @@ go vet ./...
go test ./...
```

The portable core includes `j52` through `j56` and `j58` under a normal product
binary. `j57` is source-coupled, so build its tagged product binary from the
repository root, then run it from `bench/`:

```bash
# From the repository root.
go build -tags bench_fixture -o /path/to/gentle-ai ./cmd/gentle-ai

# From bench/, after building gentle-ai-bench above.
./gentle-ai-bench run --binary /path/to/gentle-ai --axis source-coupled --only j57-sdd-authority-drift-during-discovery-fails-closed
```
The `model-picker` axis (`j97`) and damaged-store crash-recovery journeys use
the `bench_fixture` product build tag. Build that product binary from the
repository root only when running those opt-in axes; their exact driven commands
are documented in [`bench/README.md`](bench/README.md).

Benchmark validation applies to review-lifecycle, gate, recovery, delivery, benchmark implementation/corpus/classifier, and benchmark-claim changes. For measured product-behavior changes, use driven mode and report the command, tested binary or commit, selected subset or axes, and result summary. Compare before and after only when claiming a measured friction change. For unrelated changes, mark benchmark validation `N/A` with a brief reason.

Expand Down
Loading
Loading