Repository navigation
Fix: About page renders blank (missing comma in timeline array) - #103
Merged
Merged
Conversation
The v3.1 timeline entry had no trailing comma, so the v4.0 entry parsed as an index into it: [...]['2026 Q3', '...'] evaluates to undefined. events then held an undefined item, ev[0] threw a TypeError inside renderAbout, and #/about rendered nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
https://genai-security-project.github.io/crosswalk/#/about renders blank.
Root cause
In
renderAbout(docs/index.html:5617), the2026 Q2/ v3.1 timeline entry had no trailing comma. The2026 Q3/ v4.0 line that followed parsed as a property access on it:['2026 Q2', '…']['2026 Q3', '…']. The comma operator reduces the key to the v4.0 text, and that key doesn't exist on the array, so the result isundefined.eventsthen had 7 items, one of themundefined, andev[0]threw aTypeErrorthat stopped the page from rendering. The line came in with #12.Fix
Add the one missing comma. No structural change. The v4.0 timeline text that was already there now shows up.
Verification
eventsliteral: before the fix it had 7 items, one not an array; after, 8 items, all arrays.docs/index.htmlfor any other line ending']followed by a line starting with[: none.npm ci --ignore-scripts && node scripts/validate.js: 0 errors (84 warnings, same as before).npm test: 77 passed, 0 failed.Needs human review and merge (C2: webapp change).
🤖 Generated with Claude Code