Add key binding to toggle nick list visibility - #10
Conversation
|
ok wow i am just now realizing a lot of those comments in the code i should've expunged and made as comments here in the PR instead. me silly |
fcf1563 to
f9ff7a6
Compare
|
OK, I updated based on your comments left in &cove, as well as running I also decided to allow you to make edits to my branch after all, since cove is "your baby" :D |
|
I also just remembered there is already a pbln format in cove, namely in the room list :D |
oh shiiiit, you're right. i also forgot lmao Should the collapsed nick list use that format instead? (I'm not a big fan of "lurker" being abbreviated as 'l' (lowercase ell) tho :S) I see that takes yet another, entirely different approach to assembly by using an |
|
No, I think the collapsed nick list format should look similar to the expanded nick list headings. |
Closes Garmelon#5 Note: I consider this to be a handy feature not just for narrow windows, but for whenever one desires to use the full width of a terminal window. Thanks to Garmy for all his help & advice with Rust! :D
f9ff7a6 to
24bf9c3
Compare
|
OK, I implemented the changes (more or less) from review which I agreed with or didn't care about, along with adding a note about the tricksy leading space :P, and moving I think "show or hide" is a little better than "collapse or expand", but meh, doesn't matter too much. I do however still feel strongly that |
Closes #5
this commit actually works perfectly now, it's only still 'WIP' so you can give case of code critiques (INB4
add_summary_bitis too DRY xD), and for discussion of the Right PBLN/summary format. but yeah! otherwise it works 100% how one would hope/expect! (well, AFAICT -- i did not e.g. test turning off internet whilst nick list collapsed...)Thank you for all your help & advice with Rust, Garmy! :D
(and yes, no access 4 u to my branch this time >:P plz tell me how 2 fix instead 😇, and i will amend & force push myself)