Skip to content

Add key binding to toggle nick list visibility - #10

Open
jeremyredhead wants to merge 1 commit into
Garmelon:masterfrom
jeremyredhead:hideable-nicklist
Open

Add key binding to toggle nick list visibility#10
jeremyredhead wants to merge 1 commit into
Garmelon:masterfrom
jeremyredhead:hideable-nicklist

Conversation

@jeremyredhead

Copy link
Copy Markdown
Contributor

Closes #5

this commit actually works perfectly now, it's only still 'WIP' so you can give case of code critiques (INB4 add_summary_bit is too DRY xD), and for discussion of the Right PBLN/summary format. but yeah! otherwise it works 100% how one would hope/expect! (well, AFAICT -- i did not e.g. test turning off internet whilst nick list collapsed...)

Thank you for all your help & advice with Rust, Garmy! :D

(and yes, no access 4 u to my branch this time >:P plz tell me how 2 fix instead 😇, and i will amend & force push myself)

Comment thread cove/src/ui/euph/room.rs Outdated
@jeremyredhead

Copy link
Copy Markdown
Contributor Author

ok wow i am just now realizing a lot of those comments in the code i should've expunged and made as comments here in the PR instead. me silly

@jeremyredhead
jeremyredhead marked this pull request as ready for review May 9, 2026 04:27
@jeremyredhead

Copy link
Copy Markdown
Contributor Author

OK, I updated based on your comments left in &cove, as well as running cargo fmt :P

I also decided to allow you to make edits to my branch after all, since cove is "your baby" :D

Comment thread cove-config/src/keys.rs Outdated
Comment thread cove/src/ui/euph/nick_list.rs
Comment thread cove/src/ui/euph/nick_list.rs
Comment thread cove/src/ui/euph/nick_list.rs
Comment thread cove/src/ui/euph/nick_list.rs Outdated
Comment thread cove/src/ui/euph/nick_list.rs
Comment thread cove/src/ui/euph/nick_list.rs Outdated
Comment thread cove/src/ui/euph/nick_list.rs Outdated
Comment thread cove/src/ui/euph/nick_list.rs
Comment thread cove-config/src/keys.rs Outdated
Comment thread cove-config/src/keys.rs Outdated
@Garmelon

Garmelon commented May 9, 2026

Copy link
Copy Markdown
Owner

I also just remembered there is already a pbln format in cove, namely in the room list :D

@jeremyredhead

Copy link
Copy Markdown
Contributor Author

I also just remembered there is already a pbln format in cove, namely in the room list :D

oh shiiiit, you're right. i also forgot lmao

Should the collapsed nick list use that format instead? (I'm not a big fan of "lurker" being abbreviated as 'l' (lowercase ell) tho :S)

I see that takes yet another, entirely different approach to assembly by using an array vector :D

@Garmelon

Garmelon commented May 9, 2026

Copy link
Copy Markdown
Owner

No, I think the collapsed nick list format should look similar to the expanded nick list headings.

@jeremyredhead jeremyredhead changed the title WIP: Add key binding to toggle nick list visibility Add key binding to toggle nick list visibility May 9, 2026
Closes Garmelon#5

Note: I consider this to be a handy feature not just for narrow windows,
but for whenever one desires to use the full width of a terminal window.

Thanks to Garmy for all his help & advice with Rust! :D
@jeremyredhead

Copy link
Copy Markdown
Contributor Author

OK, I implemented the changes (more or less) from review which I agreed with or didn't care about, along with adding a note about the tricksy leading space :P, and moving let mut list_builder into the else branch -- yeah yeah, i'm sure it's optimized out by Rust compiler but uhh the moment I noticed it I was bothered :P (why am I summarizing what is already available with the Compare link? IDK, I'm Craaazzyy~)

I think "show or hide" is a little better than "collapse or expand", but meh, doesn't matter too much.

I do however still feel strongly that P1 B2 ... looks better than P(1) B(2) ... in practice, even if the latter seems intuitively/logically superior. But obviously change that if you want. Either way I think this is ready to merge. (actually, the previous iteration was too... the fact that its commit message started with "WIP:" was a mistake on my part >.>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Hideable Nicklist

2 participants