Thermos Compat #282
Open
Thermos Compat #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nitpick, but please don't alter the contents of the license header. Probably just some over-eager grammar corrector. |
Author
This is just copying what is the in LICENSE file in the root of this repo. I can revert this if you'd like. It was auto generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all relevant issues I saw with EID related to thermos compatibility issues, as well as the GTNH version of Galaxy-Space.
Currently, the biggest change needed was disabling the nibble array efficiency changes here: https://github.com/GTNewHorizons/Thermos/blob/1.7.10/patches/net/minecraft/world/chunk/NibbleArray.java.patch This might be better handled with something related to changing how the Managers handle the data if they detect thermos to be loaded, but I found this to be much more all encompassing, as other side effects from nibble array data being null didn't show up. These issues could be hiding, so I just went fro the all in one fix.