Fix 'Add to Stack' button showing for technologies already in the stack#4
Open
stackedsax wants to merge 1 commit into
Open
Fix 'Add to Stack' button showing for technologies already in the stack#4stackedsax wants to merge 1 commit into
stackedsax wants to merge 1 commit into
Conversation
isAlreadyAdded was only checking the currently selected stage, so clicking a technology from the canvas (where no stage is selected in the panel) always showed the Add button even if the tech was already in the stack. Now checks across all stages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for mlops-studio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the stack builder modal state so technologies already present in any stage are recognized as already added, addressing the incorrect Add to Stack button when opening a technology from the canvas.
Changes:
- Replaces the selected-stage-only membership check with a stack-wide check across all stage technology arrays.
- Keeps the resulting
isAlreadyAddedvalue wired intoTechnologyModal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+179
to
+183
| const isAlreadyAdded = selectedTechnology | ||
| ? Object.values(currentStack.technologies) | ||
| .flat() | ||
| .some(t => t.id === selectedTechnology.id) | ||
| : false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAlreadyAddedwas only checkingcurrentStack.technologies[selectedStage], so clicking a technology directly from the canvas (where no stage is selected in the left panel) always showed the Add to Stack button — even if the technology was already in the stack somewhereFix: check across all stages with
Object.values(currentStack.technologies).flat()Test plan
🤖 Generated with Claude Code