Added MS build benchmarking#23
Conversation
|
|
||
| def download_file(url, filename): | ||
| """ Download file from url and save it to filename""" | ||
| subprocess.run(['powershell', 'Invoke-WebRequest', '-Uri', |
There was a problem hiding this comment.
Delegating this to PowerShell is not very elegant. I'm sure there is an easy way to download files purely in Python.
|
|
||
| # Extract the tar.gz file | ||
| # extract_command = f"tar -xzf {tar_gz_file} -C {extract_path}" | ||
| subprocess.run(["tar", "-xzf", tar_gz_file, |
There was a problem hiding this comment.
Would it be possible to not use tar here, just pure python? (It makes it more portable and easier to test locally)
| SDK_VERSION = "6.0.300" | ||
| SDK_DAILY_VERSION = "8.0.1xx" |
There was a problem hiding this comment.
dotnet --version gives you back the version - it is not necessary to hardcode these values (Also hardcoding these values may lead to a mismatch between the hardcoded version and the actual version)
| WORKING_DIR = "msbuild-performance-test" | ||
| DOTNET_BASE_VERSION_URL_LINUX = "https://download.visualstudio.microsoft.com/download/pr/dc930bff-ef3d-4f6f-8799-6eb60390f5b4/1efee2a8ea0180c94aff8f15eb3af981/dotnet-sdk-6.0.300-linux-x64.tar.gz" | ||
| DOTNET_DAILY_VERSION_URL_LINUX = "https://aka.ms/dotnet/8.0.1xx/daily/dotnet-sdk-linux-x64.tar.gz" | ||
| TEST_SOLUTION_REPO_URL = "https://github.com/marcin-krystianc/TestSolutions.git" |
There was a problem hiding this comment.
See NuGet benchmarks, they check out the repo at specific commit hash (e.g.: https://github.com/G-Research/DotNetPerfMonitor/blob/main/scripts/perftests/testCases/LargeAppCPM64-142722b.ps1#L5).
It is important to do that because we want to measure performance for exactly the same state of the repo each time.
| DOTNET_BASE_VERSION_URL_LINUX = "https://download.visualstudio.microsoft.com/download/pr/dc930bff-ef3d-4f6f-8799-6eb60390f5b4/1efee2a8ea0180c94aff8f15eb3af981/dotnet-sdk-6.0.300-linux-x64.tar.gz" | ||
| DOTNET_DAILY_VERSION_URL_LINUX = "https://aka.ms/dotnet/8.0.1xx/daily/dotnet-sdk-linux-x64.tar.gz" | ||
| TEST_SOLUTION_REPO_URL = "https://github.com/marcin-krystianc/TestSolutions.git" | ||
| TEST_REPO_NAME = "TestSolutions" |
There was a problem hiding this comment.
This name can be derived from the repo URL (as we do it here for example https://github.com/G-Research/DotNetPerfMonitor/blob/main/scripts/perftests/testCases/LargeAppCPM64-142722b.ps1#L13)
2 participants
No description provided.