Fix reflection correctness edge cases#149
Conversation
|
Thanks. Please do in fact run the tests and formatter locally before pushing, to avoid churn on the PR. As a matter of coding style, I'd recommend asking Codex to write tests for the changes it makes, à la red-green TDD. |
|
Thanks for the nudge. I added focused regressions for each reported edge case and ran Fantomas, restore, build, and the full |
ad99d14 to
f198ee5
Compare
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
f198ee5 to
3f4922b
Compare
|
Small follow-up after the branch rebase: I rebased this over current main on June 8 after the upstream workflow updates. The branch is mergeable again, and git diff --check passed against origin/main...HEAD; the intended reflection-correctness diff remains the same in scope. For review context, the earlier remote Linux validation on this patch was Fantomas check, restore, build, and the net8.0 test suite, with 110 tests passed. Upstream Actions still need maintainer approval before they can run on the fork branch. |
Summary
FieldInfowhen printing non-public literal fieldsValidation
git diff --checkdotnet tool run fantomas --check .dotnet restoredotnet build --no-restoredotnet test --no-build --verbosity normal --framework net8.0(110 tests passed)Fixes #122