Add notification sound volume and custom sounds - #2830
Open
ChocoTonic wants to merge 3 commits into
Open
ChocoTonic wants to merge 3 commits into
ChocoTonic wants to merge 3 commits into
Conversation
ChocoTonic
marked this pull request as draft
August 30, 2026 23:07
Contributor
Author
|
Implemented the notification sound settings follow-up and tested it in a packaged Windows build.
Related community request: https://community.getmailspring.com/t/add-a-receive-sound-that-is-selectable-for-incoming-email/14455 |
ChocoTonic
marked this pull request as ready for review
August 31, 2026 05:34
bengotow
pushed a commit
that referenced
this pull request
Sep 4, 2026
Bug-fix pass against v1.24.0 (released 9/1) plus six new forum threads since 08-28: dark-theme image/text inversion (traced to the blanket invert() filter in email-frame.less, two contributor PRs open), notification volume/custom-sound requests (PR #2830 open), and a sync-accounts-across-devices feature request. Updated the two carried-forward items whose fix (PR #2821, scrollbar glitch) has now actually shipped rather than just being merged. Also flags a new calendar-roadmap thread where two contributors are asking directly for maintainer direction, and reiterates that this pipeline has produced fourteen weeks of researched drafts with none ever reviewed or posted (discourse-posted-ids.json unchanged since May). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VAwTY7mBdTEsnUkmzgHDqE
|
Looking forward to this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add notification sound volume and custom sounds
Summary
with Play Test Sound and reset-to-default actions.
sounds retain their existing behavior.
selection is missing, unsupported, or cannot be played.
and reject relative paths, non-regular files, empty files, and files over 25 MiB.
SoundRegistrywith reusable per-play volume and source options, keepingthe preference UI, sound selection, and audio playback concerns separate.
Silence audio in native Windows notifications #2619, which ensures native toast audio does not bypass Mailspring's playback
settings.
The work is organized as two focused commits in this PR: the first introduces the
volume control and reusable playback option, and the second adds custom sound
selection on top of that foundation.
Testing
volume values, custom sources, and decode-error fallback.
unsupported selections.
actions.
only to notification playback.
npm run lint:checkpassed through the production resolver and Content Security Policy.
npm run build(produced the macOS arm64 app and ZIP)npm run typecheckreaches the full project and reports three existing errorsoutside this change: the
marginTypeoption inprint-window.tsand twoinertattribute errors in
sheet-container.tsx. It reports no errors in files changed bythis PR.
Feature requests and related material
Per-filter notification sounds remain out of scope for this change.