Various fixes required for latest python versions#6
Conversation
…ix deprecation warning about abc.traversable
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project for compatibility with the latest Python versions by addressing deprecation warnings, restructuring configuration files to follow current best practices, and enhancing CI testing with coverage reporting.
- Fixes deprecation warning by migrating from
importlib.abc.Traversabletoimportlib.resources.abc.Traversable - Restructures
pyproject.tomlto follow PEP 621 standards with a dedicated[project]section and expanded author information - Updates version to "26.01.06" across all relevant files
- Enhances CI workflow with coverage reporting, updated GitHub Actions versions, and multi-OS testing (Ubuntu and macOS)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_phase.py | Updates version assertion to "26.01.06" |
| tests/conftest.py | Fixes deprecation by importing Traversable from importlib.resources.abc |
| pyproject.toml | Restructures to PEP 621 format, adds detailed author list, updates dependencies, and bumps version |
| aragog/init.py | Fixes deprecation by importing Traversable from importlib.resources.abc and updates version |
| .github/workflows/ci_tests.yml | Updates to Actions v5, adds macOS testing, integrates coverage reporting, and adjusts Python version matrix |
Comments suppressed due to low confidence (2)
.github/workflows/ci_tests.yml:26
- The CI workflow now tests Python versions 3.11, 3.12, and 3.13, but pyproject.toml still specifies
python = ">=3.10". This inconsistency means Python 3.10 is claimed to be supported but is no longer tested. Either update the pyproject.toml to requirepython = ">=3.11"or add Python 3.10 back to the CI test matrix.
.github/workflows/ci_tests.yml:26 - Missing space after comma in the Python version list. Should be
["3.11", "3.12", "3.13"]with consistent spacing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
These changes seem to resolve the recent version issues. PROTEUS tests should now pass, once an aragog release has been made. Ready for review. |
|
I presume for making a new release we will have to sever the connection to the main aragog repo, correct? |
|
I don't think so. It should still be possible to make a release while keeping the current state of things. |
|
Is the release then here on the fork? If so, which version tag are we going to use, CalVer? |
timlichtenberg
left a comment
There was a problem hiding this comment.
Great, thanks for making the changes!
|
CalVer (without a 'v' prefix) makes sense, since it would then be consistent with the other FWL modules. |
|
Thank you, @timlichtenberg! |
abc.traversablepyproject.tomlwith authors, and moved keys to recommended sections