Merged
Conversation
- Fix np.bool_ deprecated type annotation in utilities.py - Add .item() to mantle_mass, solution_top_temperature, time_range properties - Add .item() to get_planet_density return value - Ensures all methods returning float return Python floats, not numpy scalars
timlichtenberg
added a commit
to FormingWorlds/PROTEUS
that referenced
this pull request
Jan 2, 2026
Now that NumPy 2.0 fixes are merged to aragog main (PR #5), remove the temporary test branch reference from CI workflow. Related: FormingWorlds/aragog#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NumPy 2.0 compatibility issues that cause
TypeError: only 0-dimensional arrays can be converted to Python scalarsthroughout the codebase.Changes
mesh.py (3 fixes)
total_volumeproperty - added.item()to convert numpy scalar to Python floatget_planet_density- added.item()to return valuevolume_averagemethod - added.item()to return valueoutput.py (4 fixes)
mantle_massproperty - added.item()conversionsolution_top_temperatureproperty - added.item()conversiontime_rangeproperty - added.item()conversion_add_scalar_variable- conditional.item()for scalar valuesutilities.py (1 fix)
is_monotonic_increasing- changed return type annotation fromnp.bool_tobool(np.bool_ deprecated in NumPy 2.0)Testing
All changes tested in PROTEUS CI with NumPy 2.0+:
Background
NumPy 2.0 changed the behavior of 0-dimensional array scalar conversion, requiring explicit
.item()calls to convert numpy scalars to Python native types. This PR ensures aragog works with both NumPy 1.x and 2.x.Related: FormingWorlds/PROTEUS CI testing infrastructure improvements